Adding L1 unprefirable bit for 1st bx in train

[lathomas]

Hello,

PR description:

This PR updates the definition of unprefirable events in NANOAOD. Since 2022, there are two categories of such events:

• events flagged as such because of trigger rules (for example: if a L1Accept happens in BX-3, BX-2/BX-1 are masked, making BX0 unprefirable). This is the original category, existing since Run 2.
• first bx in trains were made explicitly unprefirable by masking the previous bx, for part of 2022 and 2023 data.

This PR adds the second category and split the existing boolean in NANOAOD (L1_UnprefireableEvent) in two.

PR validation:

The PR succesfully passed the following test
runTheMatrix.py -l 2500.4,141.044

Note that when reemulating L1, only BX0 is reemulated, and the L1_UnprefireableEvent_FirstBxInTrain decision can't be evaluated.
It was explicitly checked in wf 141.044 that the decision is correct when L1 is not reemulated.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Backports foreseen for all future releases foreseen for reNANO of Run 3 data. (Can you please advise?)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43150/37435

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @lathomas for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks.
@gpetruc, @missirol, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[lathomas]

FYI @aloeliger @eyigitba

[lathomas]

Hello @vlimant @simonepigazzini a kind reminder of this PR. Can you already trigger the tests? Thanks.

[simonepigazzini]

enable nano

[simonepigazzini]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77d55f/35621/summary.html
COMMIT: 8d9c366
CMSSW: CMSSW_13_3_X_2023-11-05-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43150/35621/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 121 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 140 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 1790
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361198
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16314
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16314
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.531	2.531	0.000 ( +0.0% )	5.34	5.30	+0.7%	2.102	2.103
2500.001	2.677	2.677	0.000 ( +0.0% )	4.75	4.73	+0.6%	2.124	2.135
2500.002	2.611	2.611	0.000 ( +0.0% )	4.97	4.92	+0.9%	2.141	2.146
2500.01	1.304	1.304	0.000 ( +0.0% )	9.87	9.97	-1.0%	2.102	2.246
2500.011	1.717	1.717	0.000 ( +0.0% )	5.35	5.32	+0.6%	1.927	2.047
2500.012	1.564	1.564	-0.000 ( -0.0% )	7.62	7.62	+0.0%	1.899	2.310
2500.1	2.183	2.183	0.000 ( +0.0% )	5.38	5.33	+0.8%	1.958	1.960
2500.2	2.294	2.294	0.000 ( +0.0% )	6.16	6.12	+0.7%	1.850	1.898
2500.21	1.170	1.170	0.000 ( +0.0% )	4.39	4.40	-0.3%	1.872	1.871
2500.211	1.531	1.531	0.000 ( +0.0% )	3.85	3.89	-1.2%	1.966	1.970
2500.3	2.050	2.050	-0.000 ( -0.0% )	12.87	12.98	-0.8%	1.883	1.879
2500.31	1.245	1.245	0.000 ( +0.0% )	20.37	20.56	-0.9%	2.252	2.285
2500.311	1.631	1.631	0.000 ( +0.0% )	14.26	14.39	-1.0%	2.325	2.361
2500.4	2.050	2.050	-0.000 ( -0.0% )	12.94	12.98	-0.2%	1.887	1.886
2500.5	19.556	19.544	0.012 ( +0.1% )	1.39	1.27	+9.0%	1.301	1.296

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[simonepigazzini]

@lathomas I think we should backport this to 13_3_X since this will now be integrated in 14_0_X. We had a production in 13_0_X for 2022 and 2023 data/MC but that campaign is now closed.

[simonepigazzini]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1