Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1FinalOR decision in BX-1 and -2 in NANOAOD #43306

Merged
merged 4 commits into from
Nov 24, 2023
Merged

L1FinalOR decision in BX-1 and -2 in NANOAOD #43306

merged 4 commits into from
Nov 24, 2023

Conversation

lathomas
Copy link
Contributor

PR description:

This PR adds two booleans to NANOAOD (L1_FinalOR_BXmin1, L1_FinalOR_BXmin2) checking whether the L1 final or was fired in BX-2 or -1 (which would lead the BX0 to be masked by trigger rules).

PR validation:

The NANO steps of workflows 2500.4, 141.044 ran succesfully. It was explicitly checked on a few events known to prefire that the boolean decisions are correct.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

My understanding is that a backport to 13_3_X is needed for future reNANO of 2022/2023 (?).

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Nov 16, 2023
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43306/37751

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43306/37752

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lathomas for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@simonepigazzini, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@simonepigazzini
Copy link
Contributor

Hi @lathomas, talks for future reNANOs are ongoing. It would indeed be good to have this change backported to 13_3 as well.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-800e4d/35904/summary.html
COMMIT: db6487f
CMSSW: CMSSW_14_0_X_2023-11-16-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43306/35904/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 301 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363070
  • DQMHistoTests: Total failures: 1397
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361651
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16335
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.540 2.539 0.000 ( +0.0% ) 5.32 5.34 -0.4% 2.127 2.123
2500.001 2.686 2.685 0.000 ( +0.0% ) 4.80 4.78 +0.5% 2.570 2.539
2500.002 2.622 2.622 0.000 ( +0.0% ) 4.96 4.94 +0.4% 2.540 2.540
2500.01 1.311 1.311 0.000 ( +0.0% ) 9.98 9.90 +0.8% 2.232 2.164
2500.011 1.726 1.726 -0.000 ( -0.0% ) 5.35 5.29 +1.1% 2.441 2.313
2500.012 1.572 1.572 0.000 ( +0.0% ) 7.39 7.43 -0.5% 2.337 2.244
2500.1 2.190 2.190 0.000 ( +0.0% ) 5.36 5.34 +0.3% 1.979 1.980
2500.2 2.301 2.301 0.000 ( +0.0% ) 6.10 6.08 +0.4% 1.896 1.894
2500.21 1.177 1.177 -0.000 ( -0.0% ) 4.43 4.42 +0.1% 2.195 2.178
2500.211 1.539 1.539 0.000 ( +0.0% ) 3.89 3.89 +0.1% 2.274 2.253
2500.3 2.057 2.057 -0.000 ( -0.0% ) 12.95 12.92 +0.3% 1.885 1.884
2500.31 1.253 1.252 0.000 ( +0.0% ) 20.51 20.58 -0.3% 2.278 2.249
2500.311 1.639 1.638 0.000 ( +0.0% ) 14.27 14.58 -2.2% 2.357 2.328
2500.4 2.057 2.057 -0.000 ( -0.0% ) 12.94 12.87 +0.6% 1.884 1.881
2500.5 19.575 19.556 0.019 ( +0.1% ) 1.35 1.44 -6.2% 1.300 1.294

@lathomas
Copy link
Contributor Author

I don't think the reported errors are related to this PR which doesn't touch RECO. @simonepigazzini any thought? Thanks.

@simonepigazzini
Copy link
Contributor

I agree, I will retrigger the tests anyway. It won't take long anyway

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-800e4d/35917/summary.html
COMMIT: db6487f
CMSSW: CMSSW_14_0_X_2023-11-17-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43306/35917/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 400 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363070
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3363041
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16335
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.540 2.539 0.000 ( +0.0% ) 5.34 5.31 +0.5% 2.101 2.011
2500.001 2.686 2.685 0.000 ( +0.0% ) 4.79 4.75 +0.7% 2.128 2.418
2500.002 2.622 2.622 0.000 ( +0.0% ) 4.97 4.96 +0.2% 2.144 2.396
2500.01 1.311 1.311 0.000 ( +0.0% ) 9.97 9.74 +2.4% 1.980 2.080
2500.011 1.726 1.726 -0.000 ( -0.0% ) 5.34 5.24 +1.9% 2.015 2.227
2500.012 1.572 1.572 0.000 ( +0.0% ) 7.66 7.42 +3.2% 2.031 2.154
2500.1 2.190 2.190 0.000 ( +0.0% ) 5.37 5.30 +1.4% 1.965 1.880
2500.2 2.301 2.301 0.000 ( +0.0% ) 6.19 6.17 +0.4% 1.853 1.795
2500.21 1.177 1.177 -0.000 ( -0.0% ) 4.37 4.40 -0.8% 1.871 2.049
2500.211 1.539 1.539 0.000 ( +0.0% ) 3.84 3.77 +1.9% 1.969 2.091
2500.3 2.057 2.057 -0.000 ( -0.0% ) 12.87 13.05 -1.4% 1.889 1.788
2500.31 1.253 1.252 0.000 ( +0.0% ) 20.52 20.38 +0.7% 2.284 2.138
2500.311 1.639 1.638 0.000 ( +0.0% ) 14.19 14.31 -0.8% 2.362 2.175
2500.4 2.057 2.057 -0.000 ( -0.0% ) 12.85 12.85 -0.0% 1.884 1.794
2500.5 19.575 19.556 0.019 ( +0.1% ) 1.11 1.37 -19.2% 1.283 1.298

@lathomas
Copy link
Contributor Author

The relvals timed out after 4 hours.

I guess this is the issue ?

@vlimant
Copy link
Contributor

vlimant commented Nov 20, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-800e4d/35955/summary.html
COMMIT: db6487f
CMSSW: CMSSW_14_0_X_2023-11-20-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43306/35955/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 313 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363868
  • DQMHistoTests: Total failures: 1394
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362452
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16335
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.539 2.539 0.000 ( +0.0% ) 5.29 5.33 -0.7% 2.121 2.070
2500.001 2.686 2.685 0.000 ( +0.0% ) 4.80 4.79 +0.2% 2.529 2.489
2500.002 2.622 2.622 0.000 ( +0.0% ) 4.93 4.93 -0.0% 2.534 2.482
2500.01 1.310 1.310 0.000 ( +0.0% ) 9.95 9.63 +3.3% 2.240 2.118
2500.011 1.726 1.726 0.000 ( +0.0% ) 5.31 5.22 +1.8% 2.415 2.290
2500.012 1.572 1.572 0.000 ( +0.0% ) 7.67 7.45 +2.9% 2.340 2.195
2500.1 2.190 2.191 -0.000 ( -0.0% ) 5.37 5.33 +0.8% 1.981 1.976
2500.2 2.301 2.301 0.000 ( +0.0% ) 6.14 6.18 -0.6% 1.896 1.890
2500.21 1.177 1.177 0.000 ( +0.0% ) 4.40 4.38 +0.6% 2.173 2.137
2500.211 1.540 1.540 0.000 ( +0.0% ) 3.89 3.84 +1.3% 2.250 2.151
2500.3 2.057 2.056 0.000 ( +0.0% ) 13.02 12.94 +0.6% 1.883 1.883
2500.31 1.253 1.253 -0.000 ( -0.0% ) 20.36 20.71 -1.7% 2.251 2.249
2500.311 1.639 1.639 0.000 ( +0.0% ) 14.28 14.21 +0.5% 2.330 2.221
2500.4 2.057 2.056 0.000 ( +0.0% ) 12.99 12.95 +0.3% 1.883 1.883
2500.5 19.575 19.556 0.019 ( +0.1% ) 1.42 1.30 +9.3% 1.299 1.291

@lathomas
Copy link
Contributor Author

Hello @vlimant @simonepigazzini This time the tests succeeded. Can you review the PR and eventually sign off?

Thanks,
Laurent

@lathomas lathomas mentioned this pull request Nov 24, 2023
Merged
@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7d5cb36 into cms-sw:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@lathomas @cmsbuild @simonepigazzini @vlimant @antoniovilela