Add superclusterEta of photon in NANOAOD

[Prasant1993]

PR description:

This PR is to add the superclusterEta of photon in NanoAOD.
In case of electron "deltaEtaSC" is stored in NanoAOD from which we can get the supercluster Eta easily.
Such a variable was never stored for photon before in NanoAOD.
Photon supercluster eta is w.r.t 0,0,0, while photon eta is w.r.t primary vertex.
Currently this variable is being calculated from photon eta in NanoAOD using the code provided by EGM POG : https://swmukher.web.cern.ch/swmukher/scEtaPhoNanoAOD.C
However, we see non-negligible differences for this computed variable and the direct supercluster Eta from MiniAOD. The difference is more in EB than EE.
EGM report here : https://indico.cern.ch/event/1340058/contributions/5641368/attachments/2742887/4771900/Photon_scEta_difference.pdf
From Hgg analysis team, similar difference in the supercluster Eta has also been seen.
Hgg report here[Slide 8] : https://indico.cern.ch/event/1233738/contributions/5474144/attachments/2675923/4640510/2023_LMComparions_UL18_Hgg.pdf
Since it is an important variable, we think it may be stored in NanoAOD.

PR validation:

runTheMatrix tests have been successfully run for the following workflow :

• runTheMatrix.py -l 12434.0

Backport

We target this to go in Nano V13 for now. backport might be required if the Nano production happens in the earlier CMSSW release.

Tagging EGM L2 convenors @a-kapoor and @RSalvatico
Hgg convenors @lfinco , @fcouderc, @JaLuka98

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43198/37519

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): EGamma custom nano  #42607

[cmsbuild]

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@simonepigazzini, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[simonepigazzini]

enable nano

[simonepigazzini]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75663c/35626/summary.html
COMMIT: f136552
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43198/35626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 146 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 1786
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.3169999999999993 KiB( 49 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 0.259 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): 0.126 KiB Physics/NanoAODDQM
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16314
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16314
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.6949999999999994 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): 0.259 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.011,... ): 0.126 KiB Physics/NanoAODDQM
• Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.535	2.531	0.004 ( +0.2% )	5.30	5.29	+0.1%	2.070	2.118
2500.001	2.680	2.677	0.003 ( +0.1% )	4.75	4.80	-0.9%	2.479	2.549
2500.002	2.616	2.611	0.005 ( +0.2% )	4.91	4.99	-1.5%	2.492	2.551
2500.01	1.307	1.304	0.003 ( +0.3% )	9.69	9.96	-2.7%	2.152	2.245
2500.011	1.721	1.717	0.004 ( +0.3% )	5.18	5.33	-3.0%	2.294	2.404
2500.012	1.567	1.564	0.004 ( +0.2% )	7.52	7.65	-1.8%	2.198	2.262
2500.1	2.187	2.183	0.004 ( +0.2% )	5.35	5.37	-0.4%	1.979	1.980
2500.2	2.297	2.294	0.004 ( +0.2% )	6.14	6.21	-1.2%	1.900	1.893
2500.21	1.174	1.170	0.003 ( +0.3% )	4.42	4.44	-0.3%	2.172	2.173
2500.211	1.535	1.531	0.004 ( +0.2% )	3.88	3.87	+0.3%	2.211	2.261
2500.3	2.053	2.050	0.003 ( +0.1% )	13.01	12.94	+0.6%	1.887	1.882
2500.31	1.248	1.245	0.003 ( +0.3% )	20.56	20.71	-0.7%	2.250	2.251
2500.311	1.634	1.631	0.004 ( +0.2% )	14.45	14.13	+2.3%	2.327	2.335
2500.4	2.053	2.050	0.003 ( +0.1% )	13.06	12.98	+0.6%	1.889	1.885
2500.5	19.544	19.544	0.000 ( +0.0% )	1.47	1.37	+7.1%	1.299	1.292

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[simonepigazzini]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[RSalvatico]

type egamma

[cmsbuild]

cms-bot internal usage