Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_13_3_X Backport] Add superclusterEta of photon in NanoAOD #43209

Conversation

Prasant1993
Copy link
Contributor

PR description:

Same as PR #43198

PR validation:

runTheMatrix tests have been successfully run for the following workflow :

  • runTheMatrix.py -l 12434.0

Backport

This PR is a backport of PR #43198
The addition of this photon variable is needed to be backported to CMSSW_13_3_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for CMSSW_13_3_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@simonepigazzini, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a79684/35685/summary.html
COMMIT: 8c476eb
CMSSW: CMSSW_13_3_X_2023-11-07-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43209/35685/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 184 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 146 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 1789
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361199
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.3169999999999993 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.259 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.126 KiB Physics/NanoAODDQM
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16314
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16314
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.6949999999999994 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.259 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.126 KiB Physics/NanoAODDQM
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.535 2.531 0.004 ( +0.2% ) 5.22 5.33 -2.2% 2.052 2.063
2500.001 2.680 2.677 0.003 ( +0.1% ) 4.74 4.77 -0.5% 2.466 2.489
2500.002 2.616 2.611 0.005 ( +0.2% ) 4.90 4.87 +0.6% 2.466 2.480
2500.01 1.307 1.304 0.003 ( +0.3% ) 9.61 9.93 -3.3% 2.128 2.172
2500.011 1.721 1.717 0.004 ( +0.3% ) 5.12 5.33 -3.9% 2.273 2.348
2500.012 1.567 1.564 0.004 ( +0.2% ) 7.44 7.48 -0.6% 2.192 2.253
2500.1 2.187 2.183 0.004 ( +0.2% ) 5.35 5.35 +0.0% 1.908 1.978
2500.2 2.297 2.294 0.004 ( +0.2% ) 6.07 6.19 -2.0% 1.815 1.902
2500.21 1.174 1.170 0.003 ( +0.3% ) 4.40 4.44 -0.8% 2.090 2.174
2500.211 1.535 1.531 0.004 ( +0.2% ) 3.82 3.91 -2.3% 2.113 2.159
2500.3 2.053 2.050 0.003 ( +0.1% ) 12.62 12.97 -2.7% 1.814 1.885
2500.31 1.248 1.245 0.003 ( +0.3% ) 19.63 20.51 -4.3% 2.173 2.255
2500.311 1.634 1.631 0.004 ( +0.2% ) 13.88 14.43 -3.8% 2.205 2.335
2500.4 2.053 2.050 0.003 ( +0.1% ) 12.80 12.98 -1.4% 1.815 1.883
2500.5 19.544 19.544 0.000 ( +0.0% ) 1.26 1.29 -2.4% 1.296 1.299

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 78d36b8 into cms-sw:CMSSW_13_3_X Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants