Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DQM fed client: use rawDataRepacker for HCAL FEDIntegrity Task in HI runs #43120

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

syuvivida
Copy link
Contributor

@syuvivida syuvivida commented Oct 26, 2023

PR description:

As suggested by @mmusich, in the current heavy ion HLT menu, Dataset_HIOnlineMonitor still keeps the event product FEDRawDataCollection_rawDataCollector_*_*. This product includes non-zero suppressed Tracker FEDs and may be the cause why in some HI runs, DQM streamer files are way over the 2GB limit. Therefore, we tested the DQM client codes with a test streamer that does not contain FEDRawDataCollection_rawDataCollector_*_* and see if any DQM client crashes. We found the crash of this client fed_dqm_sourceclient-live could be easily fixed with the change of inputTag for hcalFEDIntegrityTask.tagFEDs.

With this update, the client fed_dqm_sourceclient-live could run on streamers that either include rawDataCollector or not. The PR does not rely on other PRs.

PR validation:

This PR was tested at DQM playback machines at p5 using the following streamers and run_key=hi_run, pp_run or cosmic_run. The DQM clients ran without crashing and we could see output FED histograms. For run 375252, we also ran at lxplus and compare the histograms in the output root files with this PR change (taking rawDataRepacker as input) and the default fed_dqm_sourceclient-live_cfg.py (taking rawDataCollector as input). The output histograms are identical to each other.

362321 --> hi_run, test streamer without FEDRawDataCollection_rawDataCollector_*_*
373710 --> pp_run
375252 --> hi_run
375668 --> cosmic_run

The standalone job at lxplus was run via
cmsRun DQM/Integration/python/clients/fed_dqm_sourceclient-live_cfg.py runInputDir=/eos/cms/store/group/comm_dqm/Collisions23_tempStreamers runNumber=375252 runkey=hi_run scanOnce=True

The test streamer without rawDataCollector (run 362321, LS=231) is at
/eos/cms/store/group/comm_dqm/HI_testStreamers/13_2_4_noDataRepacker/run362321/

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Oct 26, 2023
@syuvivida syuvivida changed the title [DQM fed client] use rawDataRepacker for HCAL FEDIntegrity Task in HI runs Online DQM fed client: use rawDataRepacker for HCAL FEDIntegrity Task in HI runs Oct 26, 2023
@mmusich
Copy link
Contributor

mmusich commented Oct 26, 2023

@cms-sw/hcal-dpg-l2 FYI

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43120/37378

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @syuvivida for master.

It involves the following packages:

  • DQM/Integration (dqm)

@cmsbuild, @tjavaid, @rvenditti, @syuvivida, @antoniovagnerini, @nothingface0 can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Oct 27, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-feccd5/35451/summary.html
COMMIT: 8a5af49
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43120/35451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1067
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@abdoulline
Copy link

FYI @lwang046
I don't know how to draw attention of Selim and Deniz (?)

@abdoulline
Copy link

abdoulline commented Oct 27, 2023

Not sure why 12434.7_TTbar_14TeV+2023_trackingMkFit (only) is affected

corrected private->public link (as Marco suggested)
https://tinyurl.com/ysyvlb7u

@mmusich
Copy link
Contributor

mmusich commented Oct 27, 2023

Not sure why 12434.7_TTbar_14TeV+2023_trackingMkFit (only) is affected

unrelated, see #39803 (btw, the link posted cannot be opened as the DQM session is private, the tinyurl obtainable from the anchor symbol needs to be shared instead)

@tjavaid
Copy link

tjavaid commented Oct 30, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants