-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DQM fed client: use rawDataRepacker for HCAL FEDIntegrity Task in HI runs #43120
Conversation
@cms-sw/hcal-dpg-l2 FYI |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43120/37378
|
A new Pull Request was created by @syuvivida for master. It involves the following packages:
@cmsbuild, @tjavaid, @rvenditti, @syuvivida, @antoniovagnerini, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-feccd5/35451/summary.html Comparison SummarySummary:
|
FYI @lwang046 |
Not sure why 12434.7_TTbar_14TeV+2023_trackingMkFit (only) is affected corrected private->public link (as Marco suggested) |
unrelated, see #39803 (btw, the link posted cannot be opened as the DQM session is private, the tinyurl obtainable from the anchor symbol needs to be shared instead) |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As suggested by @mmusich, in the current heavy ion HLT menu,
Dataset_HIOnlineMonitor
still keeps the event productFEDRawDataCollection_rawDataCollector_*_*
. This product includes non-zero suppressed Tracker FEDs and may be the cause why in some HI runs, DQM streamer files are way over the 2GB limit. Therefore, we tested the DQM client codes with a test streamer that does not containFEDRawDataCollection_rawDataCollector_*_*
and see if any DQM client crashes. We found the crash of this clientfed_dqm_sourceclient-live
could be easily fixed with the change of inputTag forhcalFEDIntegrityTask.tagFEDs
.With this update, the client
fed_dqm_sourceclient-live
could run on streamers that either include rawDataCollector or not. The PR does not rely on other PRs.PR validation:
This PR was tested at DQM playback machines at p5 using the following streamers and run_key=hi_run, pp_run or cosmic_run. The DQM clients ran without crashing and we could see output FED histograms. For run 375252, we also ran at lxplus and compare the histograms in the output root files with this PR change (taking rawDataRepacker as input) and the default fed_dqm_sourceclient-live_cfg.py (taking rawDataCollector as input). The output histograms are identical to each other.
362321 --> hi_run, test streamer without
FEDRawDataCollection_rawDataCollector_*_*
373710 --> pp_run
375252 --> hi_run
375668 --> cosmic_run
The standalone job at lxplus was run via
cmsRun DQM/Integration/python/clients/fed_dqm_sourceclient-live_cfg.py runInputDir=/eos/cms/store/group/comm_dqm/Collisions23_tempStreamers runNumber=375252 runkey=hi_run scanOnce=True
The test streamer without rawDataCollector (run 362321, LS=231) is at
/eos/cms/store/group/comm_dqm/HI_testStreamers/13_2_4_noDataRepacker/run362321/