Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Online DQM fed client: use rawDataRepacker for HCAL FEDIntegrity Task in HI runs (backport of 43120) #43121

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

syuvivida
Copy link
Contributor

@syuvivida syuvivida commented Oct 26, 2023

PR description:

As suggested by @mmusich, in the current heavy ion HLT menu, Dataset_HIOnlineMonitor still keeps the event product FEDRawDataCollection_rawDataCollector_*_*. This product includes non-zero suppressed Tracker FEDs and may be the cause why in some HI runs, DQM streamer files are way over the 2GB limit. Therefore, we tested the DQM client codes with a test streamer that does not contain FEDRawDataCollection_rawDataCollector_*_* and see if any DQM client crashes. We found the crash of this client fed_dqm_sourceclient-live could be easily fixed with the change of inputTag for hcalFEDIntegrityTask.tagFEDs.

With this update, the client fed_dqm_sourceclient-live could run on streamers that either include rawDataCollector or not. The PR does not rely on other PRs.

PR validation:

More information could be found in PR 43120

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of 43120
This PR could be applied on top of current existing online DQM release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2023

A new Pull Request was created by @syuvivida for CMSSW_13_2_X.

It involves the following packages:

  • DQM/Integration (dqm)

@tjavaid, @cmsbuild, @antoniovagnerini, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks.
@threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Oct 27, 2023

backport of #43120

@tjavaid
Copy link

tjavaid commented Oct 27, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07829/35452/summary.html
COMMIT: 0d8a0ed
CMSSW: CMSSW_13_2_X_2023-10-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43121/35452/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198755
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 30, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ef85bd into cms-sw:CMSSW_13_2_X Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants