Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] use rawDataRepacker in presence of hi_run run class in a bunch of DQM online clients #45682

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 9, 2024

backport of #45681

PR description:

Title says it all, for HIon run (i.e hi_run run class), use the FEDRawDataCollection_rawDataRepacker_*_* input collection instead of FEDRawDataCollection_rawDataCollector_*_* as a second step to avoid keeping it around in the stream HIDQM after the initial effort at #43120.
This PR targets to continue the work in that direction (see also discussion at CMSHLT-3306).

PR validation:

I generated some input streamer files using the recipe at https://github.com/cms-data/DQM-Integration/blob/main/README.md and then run over files generated in such a way with:

cmsRun DQM/Integration/python/clients/[*]_dqm_sourceclient-live_cfg.py runInputDir=. runNumber=362321 runkey=hi_run scanOnce=True datafnPosition=4

All clients touched in this PR run correctly.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45681 to the 2024 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 9, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Aug 9, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd3c94/40850/summary.html
COMMIT: d3b8c61
CMSSW: CMSSW_14_0_X_2024-08-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45682/40850/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Aug 14, 2024

@cms-sw/dqm-l2 please review.

@tjavaid
Copy link

tjavaid commented Aug 23, 2024

Hi @mmusich , after producing the streamers of Run 362321, we tested this PR on DQM playback machines (thanks @rseidita ). The updated clients are running OK. Please have a look at DQM^2 webpage. Please have a look at the GUI plots e.g. for SiStript workspace and let us know about your assessment.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 23, 2024

The updated clients are running OK.

Thanks, I had already checked that before submitting the PR. This is the only take home message, as I am not expecting any change from the update.

@tjavaid
Copy link

tjavaid commented Aug 24, 2024

+1

  • P5 tests OK.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9685b00 into cms-sw:CMSSW_14_0_X Aug 27, 2024
9 checks passed
@mmusich mmusich deleted the mm_dev_rawDataRepackerLabel_inHIOnlineDQM_14_0_X branch August 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants