-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] use rawDataRepacker
in presence of hi_run
run class in a bunch of DQM online clients
#45682
[14.0.X] use rawDataRepacker
in presence of hi_run
run class in a bunch of DQM online clients
#45682
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
type bug-fix |
@cmsbuild, please test |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
@cms-sw/dqm-l2 please review. |
Thanks, I had already checked that before submitting the PR. This is the only take home message, as I am not expecting any change from the update. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #45681
PR description:
Title says it all, for HIon run (i.e
hi_run
run class), use theFEDRawDataCollection_rawDataRepacker_*_*
input collection instead ofFEDRawDataCollection_rawDataCollector_*_*
as a second step to avoid keeping it around in the streamHIDQM
after the initial effort at #43120.This PR targets to continue the work in that direction (see also discussion at CMSHLT-3306).
PR validation:
I generated some input streamer files using the recipe at https://github.com/cms-data/DQM-Integration/blob/main/README.md and then run over files generated in such a way with:
All clients touched in this PR run correctly.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #45681 to the 2024 data-taking release.