Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Muon DQM invariant mass plots #43026

Closed
wants to merge 260 commits into from

Conversation

llunerti
Copy link

PR description:

This PR fixes the range of the following histograms under the Muons/diMuonHistograms area of the Offline DQM:

  • LooseLooseMuon
  • LooseLooseMuon_Barrel
  • LooseLooseMuon_EndCap
  • MediumMediumMuon
  • MediumMediumMuon_Barrel
  • MediumMediumMuon_EndCap
  • TightTightMuon
  • TightTightMuon_Barrel
  • TightTightMuon_EndCap

The ranges of all the above plots were not centered on the Z peak, so they were showing no entries (e.g. https://tinyurl.com/ytbrrk9w). To fix this I've just put the correct mass range around the Z peak (namely from HighMassMin to HighMassMax defined here).

PR validation:

I have checked that the above plots are filled as intended by running the 10842.0 Z->MuMu workflow on CMSSW_13_2_6. The Z peak was visible as expected.

FYI @caruta

wddgit and others added 30 commits July 26, 2023 17:50
…sourcing_13_2_X

[13_2_X] Improve discover method in cond2xml for read-only and patch releases
[13_2_x] PPS suppress LogErrors in Pixel unpacker
…s_in_alignment_validation

[13.2.X] Support HLT tracks in alignment validation
…Payloads_fix_BACKPORT_13_2

[13_2_X] fixed comparePayloads in LHInfo* PopCons
…erMeas_132X

add layer-TSOS compatibility check in `LayerMeasurements` [`13_2_X`]
…e_v2

[13_2_X] Add HARVEST step to SKIM WF for Run3
…tag_in_2023MC_gts

[13_2_X] Update 2023 MC GTs with the fixed L1T tag and re-snapshot the data GTs
…AreaFinder_13_2_X

[13.2.X] clear `badPixelDetsBarrel_` and `badPixelDetsEndcap_` in `PixelInactiveAreaFinder`
…rity-checks-part2

ECAL skip GPU unpacking of the rest of the block if a bad block is detected - 132x
…_post41632_132X

fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-cms-sw#41632 [`13_2_X`]
…h_static_assert

Replace the SFINAE check with static_assert [13.2.x]
…132x

[Backport 13_2_X] Fix emission veto hook
Fix error code on fallback file open error with test, 13_2_X backport
[13_2_X] Removal of StringCutObjectSelector from Muon trigger DQM
The ESProducer siPixelQualityESProducer can be removed from
the cff fragments of the HLT configurations, as it is provided by the cff file

Configuration.StandardSequences.FrontierConditions_GlobalTag_cff

This avoids picking up the version of siPixelQualityESProducer defined in ConfDB
when a command like the following is used.

cmsDriver.py step2 --conditions 130X_mcRun3_2023_realistic_relvals2023D_v1 \
--datatier GEN-SIM-DIGI-RAW --era Run3_2023 --eventcontent FEVTDEBUGHLT \
--filein "dbs:/RelValTTbar_14TeV/CMSSW_13_0_11-130X_mcRun3_2023_realistic_relvals2023D_v1_RV204-v1/GEN-SIM" \
--fileout "file:step2.root" --geometry DB:Extended --nThreads 8 --no_exec --number 1 \
--pileup 2023_Fills_8807_8901_ProjectedPileup_PoissonOOTPU \
--pileup_input das:/RelValMinBias_14TeV/CMSSW_13_0_11-130X_mcRun3_2023_realistic_relvals2023D_v1_RV204-v1/GEN-SIM \
--python_filename step_2_cfg.py --step DIGI:pdigi_valid,L1,DIGI2RAW,HLT:run3:/dev/CMSSW_13_0_0/GRun/V151

Using HLT:[db]:[config] (as opposed to HLT:[menuKeyword], e.g. HLT:GRun)
leads to a call to the function loadHltConfiguration
after the process has loaded FrontierConditions_GlobalTag_cff,
thus overwriting the ESProducer from the latter cff with
the one defined in the HLT configuration as taken from ConfDB.
For details on a concrete use case, see

https://its.cern.ch/jira/browse/PDMVRELVALS-204
Update of the scripts

HLTrigger/Configuration/test/getHLT.sh , and
HLTrigger/Configuration/test/getFrozenHLT.sh

to use an associative array to specify which
HLT configurations should be downloaded from ConfDB.

This allows for more flexibility for non-standard use cases
(e.g. having to specify different version numbers for different subtables).
In getFrozenHLT.sh , this change also avoids having
to specify the list of configurations in a separate string
(which was named TABLES prior to this commit):
now, it is sufficient to add a new configuration to the associative array.

The downside of using associative arrays is that
the configurations are not downloaded anymore in a specific order,
but said order is (and should be) unimportant in this context.
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43026/37200

  • This PR adds an extra 12KB to repository

  • Found files with invalid states:

    • PhysicsTools/NanoAOD/plugins/MuonBeamspotConstraintValueMapProducer.cc:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment