Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed dimuon invariant mass plots range #43027

Merged
merged 3 commits into from
Feb 21, 2024
Merged

fixed dimuon invariant mass plots range #43027

merged 3 commits into from
Feb 21, 2024

Conversation

llunerti
Copy link

PR description:

This PR fixes the range of the following histograms under the Muons/diMuonHistograms area of the Offline DQM:

  • LooseLooseMuon
  • LooseLooseMuon_Barrel
  • LooseLooseMuon_EndCap
  • MediumMediumMuon
  • MediumMediumMuon_Barrel
  • MediumMediumMuon_EndCap
  • TightTightMuon
  • TightTightMuon_Barrel
  • TightTightMuon_EndCap

The ranges of all the above plots were not centered on the Z peak, so they were showing no entries (e.g. https://tinyurl.com/ytbrrk9w). To fix this I've just put the correct mass range around the Z peak (namely from HighMassMin to HighMassMax defined here).

PR validation:

I have checked that the above plots are filled as intended by running the 10842.0 Z->MuMu workflow on CMSSW_13_2_6. The Z peak was visible as expected.

FYI @caruta

P.S. This PR was opened by mistake in the main branch: #43026

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Oct 16, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2023 •
edited
Loading

A new Pull Request was created by @llunerti for CMSSW_13_2_X.

It involves the following packages:

  • DQMOffline/Muon (dqm)

@antoniovagnerini, @rvenditti, @cmsbuild, @tjavaid, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks.
@trocino, @HuguesBrun, @abbiendi, @bellan, @ptcox, @Fedespring, @cericeci, @calderona, @jhgoh, @rociovilar, @JanFSchulte, @barvic this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #43027 was updated. @antoniovagnerini, @tjavaid, @cmsbuild, @rvenditti, @nothingface0, @syuvivida can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #43027 was updated. @rvenditti, @cmsbuild, @tjavaid, @nothingface0, @syuvivida, @antoniovagnerini can you please check and sign again.

@tjavaid
Copy link

tjavaid commented Dec 11, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d8bc7/36411/summary.html
COMMIT: 6f31d60
CMSSW: CMSSW_13_2_X_2023-12-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43027/36411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 3198692
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@llunerti llunerti requested a review from rappoccio December 11, 2023 15:19
@llunerti
Copy link
Author

sorry @rappoccio re-requested for review by mistake...

@tjavaid
Copy link

tjavaid commented Dec 13, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

I don't see the 14_0_X version of this, where is the main branch?

@rappoccio
Copy link
Contributor

hold

  • Holding until 14_0_X is created, so we do not merge it by accident.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@llunerti llunerti mentioned this pull request Dec 21, 2023
Merged
@llunerti
Copy link
Author

@rappoccio here it is, sorry for the delay!

@antoniovilela
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

backport of #43626

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d8bc7/37418/summary.html
COMMIT: 6f31d60
CMSSW: CMSSW_13_2_X_2024-02-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43027/37418/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 3198743
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d8bc7/37435/summary.html
COMMIT: 6f31d60
CMSSW: CMSSW_13_2_X_2024-02-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43027/37435/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 3198744
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Feb 20, 2024

+1

1 similar comment
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b282b2 into cms-sw:CMSSW_13_2_X Feb 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjavaid tjavaid tjavaid left review comments

@rappoccio rappoccio rappoccio approved these changes

Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@llunerti @cmsbuild @tjavaid @rappoccio @antoniovilela