-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random DQM path order from ConfigBuilder in case of duplicate DQM sequences #42833
Fix random DQM path order from ConfigBuilder in case of duplicate DQM sequences #42833
Conversation
… sequences PromptReco for Heavy Ions was generating different RECO configurations for each job of the same Primary Dataset (and Run). This caused problems during merging as the ParameterSet registry grew. The difference between the RECO configurations was in how the DQM sequences were assigned to DQM Paths. One source for random shuffling was found to be in ConfigBuilder in case the expansion of the DQM sequence specifier leads to duplicate sequences. This commit fixes the path ordering, and adds a test for it. Co-authored-by: Christopher Jones <[email protected]>
d00ea1d
to
cda0f68
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42833/36963
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @antoniovilela, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
urgent |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6f3ed/34842/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
PromptReco for Heavy Ions was generating different RECO configurations for each job of the same Primary Dataset (and Run). This caused problems during merging as the ParameterSet registry grew, as reported in https://cms-talk.web.cern.ch/t/high-memory-usage-in-merge-alcareco-job-for-promptreco-run373536-zerobias17/29655.
The difference between the RECO configurations was in how the DQM sequences were assigned to DQM Paths. One source for random shuffling was found to be in ConfigBuilder in case the expansion of the DQM sequence specifier leads to duplicate sequences.
This PR fixes the path ordering, and adds a test for it.
PR validation:
The added unit test succeeds in 13_2_X (and failed without the fix)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 13_2_X.