Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random DQM path order from ConfigBuilder in case of duplicate DQM sequences #42833

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 20, 2023

PR description:

PromptReco for Heavy Ions was generating different RECO configurations for each job of the same Primary Dataset (and Run). This caused problems during merging as the ParameterSet registry grew, as reported in https://cms-talk.web.cern.ch/t/high-memory-usage-in-merge-alcareco-job-for-promptreco-run373536-zerobias17/29655.

The difference between the RECO configurations was in how the DQM sequences were assigned to DQM Paths. One source for random shuffling was found to be in ConfigBuilder in case the expansion of the DQM sequence specifier leads to duplicate sequences.

This PR fixes the path ordering, and adds a test for it.

PR validation:

The added unit test succeeds in 13_2_X (and failed without the fix)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 13_2_X.

… sequences

PromptReco for Heavy Ions was generating different RECO configurations
for each job of the same Primary Dataset (and Run). This caused
problems during merging as the ParameterSet registry grew.

The difference between the RECO configurations was in how the DQM
sequences were assigned to DQM Paths. One source for random shuffling
was found to be in ConfigBuilder in case the expansion of the DQM
sequence specifier leads to duplicate sequences.

This commit fixes the path ordering, and adds a test for it.

Co-authored-by: Christopher Jones <[email protected]>
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42833/36963

  • This PR adds an extra 36KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • Configuration/Applications (operations)

@cmsbuild, @antoniovilela, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

urgent

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6f3ed/34842/summary.html
COMMIT: cda0f68
CMSSW: CMSSW_13_3_X_2023-09-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42833/34842/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.5 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358019
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants