Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in DQM sequence and postSequence duplicate check in ConfigBuilder #42835

Open
makortel opened this issue Sep 20, 2023 · 3 comments
Open

Comments

@makortel
Copy link
Contributor

While investigating the ConfigBuilder code that lead to #42833, we noticed this piece of code in prepare_DQM() function

for (i,_sequence) in enumerate(postSequenceList):
#Fix needed to avoid duplication of sequences not defined in autoDQM or without a PostDQM
if (sequenceList[i]==postSequenceList[i]):
continue

raises an exception if the sequenceList has fewer elements than the postSequenceList. This behavior makes unit testing difficult as the duplicate removal (lines 2054-2056) is done only for sequenceList (after which it has fewer elements than postSequenceList). A workaround in #42833 was to modify autoDQM, but that is more of a hack than a solution.

The code snippet above was added in #28113

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @rappoccio, @smuzaffar, @makortel, @sextonkennedy, @antoniovilela can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel makortel changed the title Problem in Problem in DQM sequence and postSequence duplicate check in ConfigBuilder Sep 20, 2023
@makortel
Copy link
Contributor Author

assign operations, dqm

@cmsbuild
Copy link
Contributor

New categories assigned: operations,dqm

@fabiocos,@tjavaid,@davidlange6,@micsucmed,@nothingface0,@rvenditti,@rappoccio,@emanueleusai,@syuvivida,@antoniovilela,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants