Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Fix random DQM path order from ConfigBuilder in case of duplicate DQM sequences #42834

Merged

Conversation

makortel
Copy link
Contributor

PR description:

Backport of #42833. Original description

PromptReco for Heavy Ions was generating different RECO configurations for each job of the same Primary Dataset (and Run). This caused problems during merging as the ParameterSet registry grew, as reported in https://cms-talk.web.cern.ch/t/high-memory-usage-in-merge-alcareco-job-for-promptreco-run373536-zerobias17/29655.

The difference between the RECO configurations was in how the DQM sequences were assigned to DQM Paths. One source for random shuffling was found to be in ConfigBuilder in case the expansion of the DQM sequence specifier leads to duplicate sequences.

This PR fixes the path ordering, and adds a test for it.

PR validation:

The added unit test succeeds (and failed without the fix)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42833

… sequences

PromptReco for Heavy Ions was generating different RECO configurations
for each job of the same Primary Dataset (and Run). This caused
problems during merging as the ParameterSet registry grew.

The difference between the RECO configurations was in how the DQM
sequences were assigned to DQM Paths. One source for random shuffling
was found to be in ConfigBuilder in case the expansion of the DQM
sequence specifier leads to duplicate sequences.

This commit fixes the path ordering, and adds a test for it.

Co-authored-by: Christopher Jones <[email protected]>
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2023

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/Applications (operations)

@cmsbuild, @antoniovilela, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7b15/34843/summary.html
COMMIT: fa87b9c
CMSSW: CMSSW_13_2_X_2023-09-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42834/34843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198243
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198209
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

urgent

@makortel
Copy link
Contributor Author

backport of #42833

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7b59bcf into cms-sw:CMSSW_13_2_X Sep 21, 2023
@makortel makortel deleted the configBuilderDQMSequenceOrder_132x branch October 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants