Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackPort(#42745) Phase2 MuonHLTSeed MVA Classifier to CMSSW_13_1_X for AR #42822

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

swkim95
Copy link
Contributor

@swkim95 swkim95 commented Sep 19, 2023

PR description:

This is backport PR of #42745 to CMSSW_13_1_X.

PR for Phase2 version of MuonHLTSeedMVAClassifier which is already implemented in Run3.
Phase2 version uses L1TkMuon-related variables to classify IO triplet TrajectorySeed and choose seeds which are likely to build tracks.

The materials related to this PR were presented in HLT upgrade meetings are listed below.
5th Sep : https://indico.cern.ch/event/1322372/contributions/5564947/subcontributions/440622/attachments/2708948/4703657/2023Sep05_SeedClassifier_update.pdf
22nd Aug : https://indico.cern.ch/event/1317689/contributions/5543745/subcontributions/438812/attachments/2701219/4688626/2023Aug22_SeedClassifier_update.pdf

This PR modifies 5 Phase2 MuonHLT paths and 1 Phase2 HLT module, and adds 1 new module. (paths and modules under HLTrigger/Configuration/python/HLT_75e33/)

  • New module hltIter2Phase2L3FromL1TkMuonPixelSeedsFiltered_cfi.py added
  • Paths changed :
    1. HLTrigger/Configuration/python/HLT_75e33/paths/HLT_IsoMu24_FromL1TkMuon_cfi.py
    2. HLTrigger/Configuration/python/HLT_75e33/paths/HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_FromL1TkMuon_cfi.py
    3. HLTrigger/Configuration/python/HLT_75e33/paths/HLT_Mu37_Mu27_FromL1TkMuon_cfi.py
    4. HLTrigger/Configuration/python/HLT_75e33/paths/HLT_Mu50_FromL1TkMuon_cfi.py
    5. HLTrigger/Configuration/python/HLT_75e33/paths/HLT_TriMu_10_5_5_DZ_FromL1TkMuon_cfi.py
  • Module changed : hltIter2Phase2L3FromL1TkMuonCkfTrackCandidates_cfi.py now uses hltIter2Phase2L3FromL1TkMuonPixelSeedsFiltered for its src.

The original PR also has CMS-Data PR : cms-data/RecoMuon-TrackerSeedGenerator#6
This CMS-Data is to use data files in https://github.com/cms-data/RecoMuon-TrackerSeedGenerator
(Should I make backport of CMS-Data for this PR also?)

PR validation:

  1. Compiling CMSSW_13_1_0 with the codes in this PR
  2. scram build code-checks, code-format done
  3. Ran Muon HLT Ntupler, and it worked fine

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2023

A new Pull Request was created by @swkim95 (Sungwon Kim) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoMuon/TrackerSeedGenerator (reconstruction)

@Martin-Grunewald, @cmsbuild, @missirol, @jfernan2, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks.
@missirol, @silviodonato, @andrea21z, @abbiendi, @SohamBhattacharya, @JanFSchulte, @Fedespring, @Martin-Grunewald, @bellan, @HuguesBrun, @jhgoh, @CeliaFernandez, @rovere, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@swkim95 swkim95 closed this Sep 19, 2023
@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

@swkim95 why was this PR closed?

@swkim95
Copy link
Contributor Author

swkim95 commented Sep 19, 2023

@mmusich Hi, I accidentally pressed enter while I was writing the description and title. Sorry for the mess... I'll make proper one right away.

@swkim95 swkim95 deleted the forPR_backportTo_CMSSW_13_1_X branch September 19, 2023 11:37
@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

@swkim95 you can just re-open this one and edit the description later

@swkim95 swkim95 restored the forPR_backportTo_CMSSW_13_1_X branch September 19, 2023 11:37
@swkim95 swkim95 reopened this Sep 19, 2023
@swkim95
Copy link
Contributor Author

swkim95 commented Sep 19, 2023

@swkim95 you can just re-open this one and edit the description later

Oh Okay, I've reopened it. Thanks for the help!

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

backport of #42745

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

type muon

@swkim95 swkim95 changed the title Backport PR for 42745, adding Phase2 Muon Seed Classifier BackPort(#42745) Phase2 MuonHLTSeed MVA Classifier to CMSSW_13_1_X for AR Sep 19, 2023
@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

test parameters:

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11d513/34823/summary.html
COMMIT: 702d957
CMSSW: CMSSW_13_1_X_2023-09-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42822/34823/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 20 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187455
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

+hlt

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 9a2154e into cms-sw:CMSSW_13_1_X Sep 19, 2023
@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants