Phase2 MuonHLTSeed MVA Classifier CMSSW_13_3_X

[swkim95]

PR description:

PR for Phase2 version of MuonHLTSeedMVAClassifier which is already implemented in Run3.
Phase2 version uses L1TkMuon-related variables to classify IO triplet TrajectorySeed and choose seeds which are likely to build tracks.

This PR does not change any other modules or codes.

The materials related to this PR were presented in HLT upgrade meetings are listed below.
5th Sep : https://indico.cern.ch/event/1322372/contributions/5564947/subcontributions/440622/attachments/2708948/4703657/2023Sep05_SeedClassifier_update.pdf
22nd Aug : https://indico.cern.ch/event/1317689/contributions/5543745/subcontributions/438812/attachments/2701219/4688626/2023Aug22_SeedClassifier_update.pdf

Will need to make new data file PR to upload the trained BDT model file (in .xml format) on ~/RecoMuon/TrackerSeedGenerator/data/ directory.

PR validation:

On CMSSW_13_3_0pre2 tested these

1. Tested if cmssw well compiles with new codes (scram b) : works fine
2. Followed "before making your pull request" and "code quality checks" part on this link : http://cms-sw.github.io/PRWorkflow.html
3. Ran Muon HLT ntupler with new classifier added, checked it working fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport PR.

[cmsbuild]

@swkim95, CMSSW_13_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36837

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • RecoMuon/TrackerSeedGenerator/python/customizerForMuonHLTSeeding.py:
    • Added: 0cf9f50
    • Deleted: 0c075a0

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36837/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36837/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36837/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36837/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36838

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • RecoMuon/TrackerSeedGenerator/python/customizerForMuonHLTSeeding.py:
    • Added: 0cf9f50
    • Deleted: 0c075a0

[cmsbuild]

A new Pull Request was created by @swkim95 (Sungwon Kim) for master.

It involves the following packages:

• RecoMuon/TrackerSeedGenerator (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@bellan, @andrea21z, @abbiendi, @JanFSchulte, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36839

ERROR: Build errors found during clang-tidy run.

RecoMuon/TrackerSeedGenerator/src/SeedMvaEstimatorPhase2.cc:298:3: error: use of undeclared identifier 'getHitL1TkVatiables'; did you mean 'getHitL1TkVariables'? [clang-diagnostic-error]
  getHitL1TkVatiables(
  ^~~~~~~~~~~~~~~~~~~
  getHitL1TkVariables
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42745/36840

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • RecoMuon/TrackerSeedGenerator/python/customizerForMuonHLTSeeding.py:
    • Added: 0cf9f50
    • Deleted: 0c075a0

[mmusich]

@cmsbuild, please test

• let's try to get a cleaner comparison with less merges in between

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fee55e/34777/summary.html
COMMIT: 5510624
CMSSW: CMSSW_13_3_X_2023-09-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42745/34777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3348648
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3348620
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

This is not a backport PR.

just to gauge urgency here, does this need to be backported to 13.1.X for the annual review or is it something for longer term?

[wonpoint4]

This PR is for the annual review, so this needs to be backported to 131X.

[mmusich]

Just a minor suggestion (feel free to discard) and a question before signing off.

[jfernan2]

+1

[mmusich]

kindly pinging @swkim95 about #42745 (review)

[mmusich]

+hlt

• PR is inline with initial description and follow-up review;
• a backport of this will be needed in CMSSW_13_1_X in order to fulfill the goals of the Upgrade HLT group for the 2023 AR;

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

This PR is for the annual review, so this needs to be backported to 131X.

@swkim95 in light of this information, please open a backport PR to 13.1.X at your earliest convenience such that it can be flagged at today's release planning meeting.

[mmusich]

type muon

[rappoccio]

+1