Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new MuonHLT Seed Classifier model files for Phase2 HLT #6

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

swkim95
Copy link
Contributor

@swkim95 swkim95 commented Sep 14, 2023

This PR adds 2 new BDT model files in .xml format.

This files are used for Phase2 MuonHLT SeedClassifier model in this CMSSW PR (cms-sw/cmssw#42745).

Used Phase2 Spring23 DYToLL, JPsi, TTLL, ZPrime for training the BDT.
The model uses L1TkMuon to classify seeds.

The materials related to this PR were presented in HLT upgrade meetings are listed below.
5th Sep : https://indico.cern.ch/event/1322372/contributions/5564947/subcontributions/440622/attachments/2708948/4703657/2023Sep05_SeedClassifier_update.pdf
22nd Aug : https://indico.cern.ch/event/1317689/contributions/5543745/subcontributions/438812/attachments/2701219/4688626/2023Aug22_SeedClassifier_update.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swkim95 (Sungwon Kim) for branch main.

@smuzaffar, @aandvalenzuela, @iarspider, @cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@antoniovilela
Copy link

please test

  • doesn't hurt

@antoniovilela
Copy link

@jfernan2, @mandrenguyen
All ok?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa4674/34810/summary.html
COMMIT: 2ca11ea
CMSSW: CMSSW_13_3_X_2023-09-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoMuon-TrackerSeedGenerator/6/34810/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358016
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link

mmusich commented Sep 19, 2023

we'll need to have this also in 13.1.X for cms-sw/cmssw#42822 .
@antoniovilela @rappoccio can you clarify what's the integration strategy for that?

@mandrenguyen
Copy link

+1

@rappoccio
Copy link

+1

@rappoccio
Copy link

we'll need to have this also in 13.1.X for cms-sw/cmssw#42822 .
@antoniovilela @rappoccio can you clarify what's the integration strategy for that?

If I recall correctly (and @smuzaffar can correct me if I'm wrong) but we need to

  • Merge this PR
  • Adjust the cms-dist/data file here on the correct branch to specify the right tag for cmsdata.

@mmusich
Copy link

mmusich commented Sep 19, 2023

@rappoccio since you already merged cms-sw/cmssw#42745 please merge this one (otherwise IBs will fail)

@antoniovilela
Copy link

merge

@mmusich
Copy link

mmusich commented Sep 19, 2023

If I recall correctly (and @smuzaffar can correct me if I'm wrong) but we need to

  • Merge this PR
  • Adjust the cms-dist/data file here on the correct branch to specify the right tag for cmsdata.

thank you @rappoccio I opened cms-sw/cmsdist#8709, hopefully that's the right move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants