Fall17V2 Electron IDs and Isolations saved only in Run2 #42726

Prasant1993 · 2023-09-05T17:24:43Z

PR description:

This PR is for saving only Fall17V2 Electron IDs and isolations in Run2. Same thing has been done for photons in PR #42255.

PR validation:

runTheMatrix tests have been successfully run for the following workflow :

runTheMatrix.py -l 12434.0

PR backport

As pointed out by Cross-POG convenors in the PR #42255 , we need backport to 13_0_X for 2022 and 2023 data/MC processing.

Tagging EGM convenors @a-kapoor , @RSalvatico

cmsbuild · 2023-09-05T17:30:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42726/36816

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): EGamma custom nano #42607

cmsbuild · 2023-09-05T17:31:22Z

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

simonepigazzini · 2023-09-05T17:55:32Z

enable nano

simonepigazzini · 2023-09-05T17:55:39Z

please test

cmsbuild · 2023-09-05T18:00:29Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48e10e/34616/summary.html
COMMIT: 0c7499b
CMSSW: CMSSW_13_3_X_2023-09-05-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42726/34616/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48e10e/34616/git-merge-result

Prasant1993 · 2023-09-05T18:42:37Z

Okay. I am rebasing the branch with the latest CMSSW_13_3_X_2023-09-05-1100 and trying to resolve the conflicts as follows :
cmsrel CMSSW_13_3_X_2023-09-05-1100
cd CMSSW_13_3_X_2023-09-05-1100/src
cmsenv
git cms-rebase-topic Prasant1993:Fall17V2_ElectronIDs_Iso_inRun2only_CMSSW_13_3_0_pre2
.....
resolving the conflict file: electrons_cff.py
.....
git add PhysicsTools/NanoAOD/python/electrons_cff.py
git rebase --continue
git cms-checkdeps -a
scram b -j4
git push -f my-cmssw Fall17V2_ElectronIDs_Iso_inRun2only_CMSSW_13_3_0_pre2

cmsbuild · 2023-09-05T18:49:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42726/36818

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): EGamma custom nano #42607

cmsbuild · 2023-09-05T18:50:06Z

Pull request #42726 was updated. @cmsbuild, @simonepigazzini, @vlimant can you please check and sign again.

simonepigazzini · 2023-09-05T19:25:35Z

enable nano

simonepigazzini · 2023-09-05T19:25:42Z

please test

cmsbuild · 2023-09-05T22:23:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48e10e/34624/summary.html
COMMIT: 46af7e8
CMSSW: CMSSW_13_3_X_2023-09-05-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42726/34624/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 59 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153414
DQMHistoTests: Total failures: 3509
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3149883
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 6 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 120 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15610
DQMHistoTests: Total failures: 280
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15330
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.460	2.460	0.000 ( +0.0% )	5.34	5.33	+0.2%	2.175	2.181
2500.001	2.596	2.596	0.000 ( +0.0% )	4.74	4.77	-0.5%	2.604	2.609
2500.002	2.512	2.512	0.000 ( +0.0% )	4.95	4.99	-0.7%	2.588	2.600
2500.01	1.253	1.253	0.000 ( +0.0% )	10.02	9.93	+1.0%	2.292	2.246
2500.011	1.620	1.620	0.000 ( +0.0% )	5.30	5.33	-0.6%	2.485	2.457
2500.012	1.502	1.502	0.000 ( +0.0% )	7.71	7.69	+0.2%	2.416	2.345
2500.1	2.118	2.153	-0.035 ( -1.6% )	5.39	5.39	+0.0%	2.044	2.047
2500.2	2.229	2.264	-0.035 ( -1.5% )	6.17	6.18	-0.3%	1.953	1.955
2500.21	1.110	1.140	-0.030 ( -2.7% )	4.41	4.44	-0.8%	2.222	2.232
2500.211	1.464	1.498	-0.034 ( -2.2% )	3.90	3.90	+0.2%	2.305	2.314
2500.3	1.967	2.003	-0.035 ( -1.8% )	13.19	13.06	+1.0%	1.753	1.758
2500.31	1.175	1.204	-0.029 ( -2.4% )	21.13	20.93	+1.0%	2.122	2.130
2500.311	1.550	1.583	-0.032 ( -2.1% )	14.77	15.21	-2.9%	2.200	2.210
2500.4	1.967	2.003	-0.035 ( -1.8% )	13.24	13.02	+1.7%	1.762	1.758

simonepigazzini · 2023-09-06T08:25:41Z

+1

cmsbuild · 2023-09-06T08:26:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

simonepigazzini · 2023-09-06T08:26:03Z

Hi @Prasant1993, please open the backport to 13_0 as well

Prasant1993 · 2023-09-06T11:22:41Z

Hi @Prasant1993, please open the backport to 13_0 as well

Yes, I will do that. Thanks.

antoniovilela · 2023-09-06T17:02:15Z

+1

cmsbuild · 2023-09-07T09:14:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48e10e/34651/summary.html
COMMIT: 46af7e8
CMSSW: CMSSW_13_3_X_2023-09-06-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42726/34651/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 341 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153414
DQMHistoTests: Total failures: 119
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 8 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15610
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15610
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.460	2.460	0.000 ( +0.0% )	5.32	5.32	+0.0%	2.172	2.116
2500.001	2.596	2.596	0.000 ( +0.0% )	4.77	4.79	-0.6%	2.579	2.538
2500.002	2.512	2.512	0.000 ( +0.0% )	4.95	5.01	-1.0%	2.581	2.539
2500.01	1.253	1.253	0.000 ( +0.0% )	9.98	9.82	+1.6%	2.286	2.203
2500.011	1.620	1.620	0.000 ( +0.0% )	5.30	5.35	-1.0%	2.411	2.354
2500.012	1.502	1.502	0.000 ( +0.0% )	7.60	7.51	+1.2%	2.313	2.297
2500.1	2.118	2.118	0.000 ( +0.0% )	5.39	5.38	+0.1%	2.021	2.027
2500.2	2.229	2.229	0.000 ( +0.0% )	6.14	6.24	-1.6%	1.942	1.946
2500.21	1.110	1.110	0.000 ( +0.0% )	4.41	4.43	-0.5%	2.213	2.209
2500.211	1.464	1.464	0.000 ( +0.0% )	3.83	3.89	-1.6%	2.294	2.290
2500.3	1.967	1.967	0.000 ( +0.0% )	12.98	13.28	-2.2%	1.750	1.746
2500.31	1.175	1.175	0.000 ( +0.0% )	20.68	21.16	-2.3%	2.115	2.116
2500.311	1.550	1.550	0.000 ( +0.0% )	14.66	15.10	-2.9%	2.198	2.200
2500.4	1.967	1.967	0.000 ( +0.0% )	13.00	13.25	-1.9%	1.751	1.749

cmsbuild added this to the CMSSW_13_3_X milestone Sep 5, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Sep 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 5, 2023

cmsbuild added tests-started and removed tests-pending labels Sep 5, 2023

cmsbuild added tests-rejected and removed tests-started labels Sep 5, 2023

Fall17 Electron IDs and Isolations saved only in Run2

46af7e8

Prasant1993 force-pushed the Fall17V2_ElectronIDs_Iso_inRun2only_CMSSW_13_3_0_pre2 branch from 0c7499b to 46af7e8 Compare September 5, 2023 18:43

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Sep 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 5, 2023

cmsbuild added tests-started and removed tests-pending labels Sep 5, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 5, 2023

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Sep 6, 2023

Prasant1993 mentioned this pull request Sep 6, 2023

[13_0_X backport] Fall17V2 Electron IDs and Isolations saved only in Run2 Nanos #42730

Merged

cmsbuild added orp-approved and removed orp-pending labels Sep 6, 2023

cmsbuild merged commit bac24a4 into cms-sw:master Sep 6, 2023

cmsbuild added tests-started and removed tests-approved labels Sep 7, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fall17V2 Electron IDs and Isolations saved only in Run2 #42726

Fall17V2 Electron IDs and Isolations saved only in Run2 #42726

Prasant1993 commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

Prasant1993 commented Sep 5, 2023 •

edited

Loading

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

simonepigazzini commented Sep 6, 2023

cmsbuild commented Sep 6, 2023

simonepigazzini commented Sep 6, 2023

Prasant1993 commented Sep 6, 2023

antoniovilela commented Sep 6, 2023

cmsbuild commented Sep 7, 2023

Fall17V2 Electron IDs and Isolations saved only in Run2 #42726

Fall17V2 Electron IDs and Isolations saved only in Run2 #42726

Conversation

Prasant1993 commented Sep 5, 2023

PR description:

PR validation:

PR backport

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

Prasant1993 commented Sep 5, 2023 • edited Loading

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

simonepigazzini commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

Comparison Summary

NANO Comparison Summary

simonepigazzini commented Sep 6, 2023

cmsbuild commented Sep 6, 2023

simonepigazzini commented Sep 6, 2023

Prasant1993 commented Sep 6, 2023

antoniovilela commented Sep 6, 2023

cmsbuild commented Sep 7, 2023

Comparison Summary

NANO Comparison Summary

Prasant1993 commented Sep 5, 2023 •

edited

Loading