Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X backport] Fall17V2 Electron IDs and Isolations saved only in Run2 Nanos #42730

Conversation

Prasant1993
Copy link
Contributor

PR description:

Backport of PR #42726. See description there.

PR validation:

Same as PR #42726.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport required for processing of 2022 and 2023 data/MC which will happen in 13_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2023

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovilela
Copy link
Contributor

please test

@Prasant1993
Copy link
Contributor Author

please test

hi @antoniovilela, We should first do "enable nano" and execute the test command.

@antoniovilela
Copy link
Contributor

please test

hi @antoniovilela, We should first do "enable nano" and execute the test command.

True, thanks.

@antoniovilela
Copy link
Contributor

please abort

@antoniovilela
Copy link
Contributor

enable nano

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-672c75/34647/summary.html
COMMIT: 3bbe255
CMSSW: CMSSW_13_0_X_2023-09-06-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42730/34647/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 229 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283193
  • DQMHistoTests: Total failures: 160
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283011
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 81 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12351
  • DQMHistoTests: Total failures: 182
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12169
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.447 2.445 0.002 ( +0.1% ) 5.44 5.37 +1.1% 2.089 2.027
2500.311 2.553 2.552 0.001 ( +0.0% ) 4.88 4.79 +1.9% 2.525 2.451
2500.312 2.498 2.496 0.001 ( +0.1% ) 5.01 5.00 +0.3% 2.509 2.439
2500.33 1.242 1.240 0.001 ( +0.1% ) 10.35 10.13 +2.1% 2.209 2.131
2500.331 1.605 1.604 0.002 ( +0.1% ) 5.48 5.45 +0.5% 2.404 2.291
2500.332 1.487 1.485 0.001 ( +0.1% ) 7.95 7.86 +1.1% 2.305 2.225
2500.401 2.123 2.158 -0.035 ( -1.6% ) 5.43 5.49 -1.0% 1.950 1.943
2500.501 1.731 1.762 -0.031 ( -1.8% ) 9.32 9.26 +0.7% 1.837 1.826
2500.511 1.116 1.146 -0.030 ( -2.6% ) 4.56 4.52 +0.7% 2.129 2.137
2500.5111 1.470 1.504 -0.034 ( -2.2% ) 3.99 4.06 -1.5% 2.209 2.215
2500.601 1.988 2.025 -0.038 ( -1.9% ) 12.71 13.21 -3.8% 1.706 1.699

@rappoccio
Copy link
Contributor

@cms-sw/xpog-l2 is this one ready to go?

@jordan-martins
Copy link
Contributor

Hi,
We should include this in a new 130X and then cut the release. We need to start the Re-mini and Re-nanos now-ish.

Thanks,
PPD
@malbouis

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 382249d into cms-sw:CMSSW_13_0_X Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants