Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] add information on first hit from HitPattern to LostTracks #42693

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 31, 2023

backport of #42681

PR description:

Title says it all, as per request here.
It will add information about the first hit in the hit pattern for lostTracks with pT > 0.95 GeV

minPtToStoreProps = cms.double(0.95),

similarly for what is already done for packedPfCandidates

if (outPtrP->back().pt() > minPtForTrackProperties_ || outPtrP->back().ptTrk() > minPtForTrackProperties_ ||
whiteList.find(ic) != whiteList.end() ||

minPtForTrackProperties = cms.double(0.95),

PR validation:

cmssw compiles.
On-file size increase in miniAOD has not been measured, but should be negligible as per reasoning in reference.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42681 to 13.1.X (meant as as intermediate backport to downstream releases)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @simonepigazzini, @mandrenguyen, @clacaputo, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @Ming-Yan, @hatakeyamak, @emilbols, @mbluj, @ahinzmann, @demuller, @seemasharmafnal, @mmarionncern, @Senphy, @jdolen, @azotz, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@rappoccio, @dpiparo, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Aug 31, 2023

type tracking

@mmusich
Copy link
Contributor Author

mmusich commented Aug 31, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc4df2/34566/summary.html
COMMIT: aa5101f
CMSSW: CMSSW_13_1_X_2023-08-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42693/34566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187125
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187088
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@simonepigazzini
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 47a4378 into cms-sw:CMSSW_13_1_X Sep 1, 2023
@mmusich mmusich deleted the add_first_hit_to_lostTracks_13_1_X branch September 1, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants