Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniAOD for EXO tracking parts #42055

Open
slava77 opened this issue Jun 22, 2023 · 15 comments
Open

miniAOD for EXO tracking parts #42055

slava77 opened this issue Jun 22, 2023 · 15 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Jun 22, 2023

Following the presentations in https://indico.cern.ch/event/1263032/timetable/
more specifically EXO
there is some need to add more information for tracks in miniAOD

For both cases some motivation from EXO would be nice as well as a contact person.

@aehart @afrankenthal please comment on possibility for someone to investigate and prepare PRs

@cms-sw/xpog-l2
@mmusich @kskovpen

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign xpog

@cmsbuild
Copy link
Contributor

New categories assigned: xpog

@simonepigazzini,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor Author

slava77 commented Jun 22, 2023

type tracking

@afrankenthal
Copy link
Contributor

@slava77 to follow up, @tvami has agreed to serve as contact point for item 2 (extending selection of tracks where dE/dX is available) and Daniel Bloch and Paul Vaucelle agreed to serve as contact points for item 1 (adding first hit in lost tracks). @aehart and I will also follow closely. It will be very good if we can make this happen within the relevant constraints. Thanks!

@slava77
Copy link
Contributor Author

slava77 commented Aug 30, 2023

#42681 has 13_3_X/master variant for lostTrack first hits

@mmusich
Copy link
Contributor

mmusich commented Aug 30, 2023

Is there interest in backports (e.g. to 13.2.x) or earlier (for remini)?

@slava77
Copy link
Contributor Author

slava77 commented Aug 30, 2023

Is there interest in backports (e.g. to 13.2.x) or earlier (for remini)?

I doubt about 13_2 use/needs (HI-specific), but here it will be least painful. So, why not.
For 13_0, a possible rereco, I suspect some configurable way to pass the no-change rules may be needed.

@mmusich
Copy link
Contributor

mmusich commented Aug 31, 2023

I doubt about 13_2 use/needs (HI-specific), but here it will be least painful. So, why not.

here's a backport: #42688

For 13_0, a possible rereco, I suspect some configurable way to pass the no-change rules may be needed.

what's the preferred way about it? Create a new modifier and have the filling of the information happen only if the modifier is active / requested?

@slava77
Copy link
Contributor Author

slava77 commented Aug 31, 2023

For 13_0, a possible rereco, I suspect some configurable way to pass the no-change rules may be needed.

what's the preferred way about it? Create a new modifier and have the filling of the information happen only if the modifier is active / requested?

In the past this was done with a run2_miniAOD_devel modifier.
OTOH, one could claim an exception to the no-change rule, since the variable is not filled at all in the baseline and is filled in this PR one could interpret this as a new variable. These are sometimes allowed.
I could suggest to just port verbatim and wait for comments.

@cms-sw/reconstruction-l2
please comment.

@mandrenguyen
Copy link
Contributor

An exception in this case sounds reasonable to me, if ORP agrees.
MiniAOD is formally XPOG responsibility, so I let them also comment.

@mmusich
Copy link
Contributor

mmusich commented Aug 31, 2023

An exception in this case sounds reasonable to me, if ORP agrees.

here are more backports:

@mandrenguyen
Copy link
Contributor

Can you please do 13.2.X as well? Not 100% obvious to me that it's useless there.

@mmusich
Copy link
Contributor

mmusich commented Aug 31, 2023

Can you please do 13.2.X as well? Not 100% obvious to me that it's useless there.

I did it already this morning, see #42055 (comment)

@mandrenguyen
Copy link
Contributor

right, sorry Marco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants