Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add information on first hit from HitPattern to lostTracks #42681

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 29, 2023

PR description:

Title says it all, as per request here.
It will add information about the first hit in the hit pattern for lostTracks with pT > 0.95 GeV

minPtToStoreProps = cms.double(0.95),

similarly for what is already done for packedPfCandidates

if (outPtrP->back().pt() > minPtForTrackProperties_ || outPtrP->back().ptTrk() > minPtForTrackProperties_ ||
whiteList.find(ic) != whiteList.end() ||

minPtForTrackProperties = cms.double(0.95),

PR validation:

cmssw compiles.
On-file size increase in miniAOD has not been measured, but should be negligible as per reasoning in reference.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

FYI:
@aehart @afrankenthal

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42681/36770

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @simonepigazzini, @mandrenguyen, @clacaputo, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @Ming-Yan, @hatakeyamak, @emilbols, @mbluj, @ahinzmann, @demuller, @seemasharmafnal, @mmarionncern, @Senphy, @jdolen, @azotz, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 30, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87c328/34536/summary.html
COMMIT: d9129d2
CMSSW: CMSSW_13_3_X_2023-08-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42681/34536/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 333 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3153095
  • DQMHistoTests: Total failures: 124
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152949
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

ping bot

@cmsbuild cmsbuild merged commit f4e3002 into cms-sw:master Aug 30, 2023
@mmusich mmusich deleted the add_first_hit_to_lostTracks branch August 30, 2023 16:56
@slava77
Copy link
Contributor

slava77 commented Aug 30, 2023

@afrankenthal @aehart
do we need backports?

@cms-sw/reconstruction-l2
if re-miniAOD campaigns are planned, it would be good to have this PR ported there.

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2023

type tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants