Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] fix removal of siStripDigis from RawToDigi task #42659

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 25, 2023

backport of #42655

PR description:

Fixes a bug introduced involuntarily at 6cc72b5

PR validation:

Run runTheMatrix.py -l 140.58,140.60 -t 4 -j 8 --ibeos successfully

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42655 for 2023 HI data-taking.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @cmsbuild, @antoniovilela, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2023

urgent

  • this has to be included in the next 13_2_X release.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2023

test parameters:

  • workflow = 140.58, 140.6

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c37646/34475/summary.html
COMMIT: 957ea8d
CMSSW: CMSSW_13_2_X_2023-08-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42659/34475/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 140.6

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2023

please test with #42661

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c37646/34478/summary.html
COMMIT: 957ea8d
CMSSW: CMSSW_13_2_X_2023-08-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42659/34478/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196410
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196388
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2023

despite the "requires external" flag (needed just for extra testing) this PR can be merged standalone.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit dae764c into cms-sw:CMSSW_13_2_X Aug 25, 2023
@mmusich mmusich deleted the fix_removal_rawToDigisTask_13_2_X branch August 25, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants