Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix removal of siStripDigis from RawToDigi task #42655

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 24, 2023

PR description:

Fixes a bug introduced involuntarily at 6cc72b5
First reported by @nothingface0

PR validation:

Run runTheMatrix.py -l 140.58,140.60 -t 4 -j 8 --ibeos successfully

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport needs to be backported to 13.2.X

@mmusich
Copy link
Contributor Author

mmusich commented Aug 24, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42655/36716

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @cmsbuild, @antoniovilela, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 24, 2023

test parameters:

  • workflows = 140.58, 140.6
  • addpkg = DQM/Integration

@mmusich
Copy link
Contributor Author

mmusich commented Aug 24, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-275221/34467/summary.html
COMMIT: 0006e46
CMSSW: CMSSW_13_3_X_2023-08-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42655/34467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 33 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3260314
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3260283
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 163 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Errors as
%MSG-w SiStripRawToDigi:  SiStripRawToDigiModule:siStripDigis  24-Aug-2023 19:16:44 CEST Run: 362321 Event: 52856098
NULL pointer to FEDRawData for FED: id 50
Note: further warnings of this type will be suppressed (this can be changed by enabling debugging printout)
%MSG
%MSG-e TooManyErrors:  SiStripRawToDigiModule:siStripDigis  24-Aug-2023 19:16:44 CEST Run: 362321 Event: 52856098
Total number of errors = 35111

have disappeared from the logs of wfs 140.58, 140.6

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7ee03e7 into cms-sw:master Aug 25, 2023
@mmusich mmusich deleted the fix_removal_rawToDigisTask branch August 25, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants