Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update 2022,2023,2024 MC GTs #42602

Merged

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Aug 18, 2023

PR description:

This PR is a combined backport of #42551 and #42601

From the partial backport of #42551 , this PR:

From backport of #42601

  • It updates the 2023 realistic MC GTs with the latest requests from pixel and ECAL in [3] and [4], and introduces a new key phase1_2023_realistic_postBPix for the MC conditions corresponding to the Run3Summer23BPix campaign

For more details, see the master PRs.

[1] https://cms-talk.web.cern.ch/t/update-zdc-geometry-for-run3-data-and-mc/24637
[2] https://cms-talk.web.cern.ch/t/mc-gt-pixel-bad-components-and-dynamic-inefficiency-payloads-for-the-upcoming-2022-mc-campaign/26670
[3] https://cms-talk.web.cern.ch/t/queues-postbpix-queues-open-for-run3summer23bpix-campaign/27818/4
[4] https://cms-talk.web.cern.ch/t/new-pixel-status-scenarios-and-probabilities-for-2023-mc/28126

GT Differences with the last ones are here:

PR validation:

Tested successfully with

  • runTheMatrix.py -l 12034.0,12434.0,12834.0,11601.0 -j 8 --ibeos
  • runTheMatrix.py -l 12430.0,12440.0 --what upgrade -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

130X backport of #42601 and #42551

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

backport of #42601

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdcf3e/34352/summary.html
COMMIT: 18a4b4c
CMSSW: CMSSW_13_0_X_2023-08-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42602/34352/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 50 lines to the logs
  • Reco comparison results: 7734 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 23944
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3257304
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdcf3e/34359/summary.html
COMMIT: 18a4b4c
CMSSW: CMSSW_13_0_X_2023-08-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42602/34359/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 274 lines from the logs
  • Reco comparison results: 7726 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 23941
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3257307
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@tvami
Copy link
Contributor

tvami commented Aug 18, 2023

+alca

  • lot of changes as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0f13b78 into cms-sw:CMSSW_13_0_X Aug 21, 2023
@saumyaphor4252 saumyaphor4252 deleted the 130X_alca-update_MC_GTs branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants