Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update SiPixel Dynamic Inefficiency tag in 2022, 2023, 2024 MC GTs #41332

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

This PR is a partial backport of #41327 and it:

  • Updates the latest SiPixel dynamic Inefficiency tag
    SiPixelDynamicInefficiency_phase1_2023_v2_fix2, Rcd:SiPixelDynamicInefficiencyRcd, Label:-
    in Phase1 2022, 2023 and 2024 MC GTs as requested in this CMS Talk post [1].

  • Apart from that, the 2023 HI realistic GT also includes the following updated spike-killer tags derived from 2022 PbPb test data

    • EcalTPGSpike_HI_Run3_12GeV_mc, Rcd:EcalTPGSpikeRcd, Label:-
    • EcalTPGFineGrainStripEE_HI_Run3_sFGVB_7ADC_mc, Rcd:EcalTPGFineGrainStripEERcd, Label:-
      (See this CMS Talk post) [2].

[1] https://cms-talk.web.cern.ch/t/request-creation-of-a-gt-with-preliminary-pixel-dynamic-inefficiency-settings/20385/15
[2] https://cms-talk.web.cern.ch/t/request-for-new-hi-mc-gts-with-realistic-spike-killer-settings-125x-130x-131x/22082/8

GT Differences with the last ones are here:

PR validation:

GTs tested locally with runTheMatrix.py -l 11634.0,7.23,7.24,159.0,12434.0,12834.0 -j 10 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Partial Backport of #41327

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0ff1/31962/summary.html
COMMIT: 62fcc26
CMSSW: CMSSW_13_0_X_2023-04-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41332/31962/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1883 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554298
  • DQMHistoTests: Total failures: 4294
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3549982
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@tvami
Copy link
Contributor

tvami commented Apr 13, 2023

backport of #41327

@tvami
Copy link
Contributor

tvami commented Apr 13, 2023

+alca

  • tests pass, widespread diffs due to redigi

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #41327

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f7133d1 into cms-sw:CMSSW_13_0_X Apr 14, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-130X_update_SiPixel_DynIneff_MC_GTs branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants