Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2023 MC GTs #42601

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Update 2023 MC GTs #42601

merged 1 commit into from
Aug 18, 2023

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Aug 18, 2023

PR description:

This PR updates in the release the 132X GTs for Run 3 MC, also adding a new key (phase1_2023_realistic_postBPix) for the "postBPix" era.

There are a few conditions updated, namely:

  • Updated ECAL conditions to best represent the collected data

    • Tags for ABC eras:

      • EcalLaserAPDPNRatiosRcd: EcalLaserAPDPNRatios_2023ABC_outliers_cleaned_3sigma_mc
      • EcalPedestalsRcd: EcalPedestals_2023ABC_corrected_mc
      • EcalTPGLinearizationConstRcd: EcalTPGLinearizationConst_2023ABC_mc
      • EcalTPGPedestalsRcd: EcalTPGPedestals_2023ABC_mc
    • Tags for D era (postBPix) and for cosmics:

      • EcalLaserAPDPNRatiosRcd: EcalLaserAPDPNRatios_2023D_outliers_cleaned_3sigma_mc
      • EcalPedestalsRcd: EcalPedestals_2023ABC_corrected_mc
      • EcalTPGLinearizationConstRcd: EcalTPGLinearizationConst_2023D_mc
      • EcalTPGPedestalsRcd: EcalTPGPedestals_2023D_mc
    • CMS Talk post in https://cms-talk.web.cern.ch/t/queues-postbpix-queues-open-for-run3summer23bpix-campaign/27818/4

  • New payloads for status of pixel bad components scenarios and probabilities

    • Tags for ABC eras:

      • SiPixelStatusScenarioProbabilityRcd: SiPixelQualityProbabilities_2023_v2_mc
      • SiPixelStatusScenariosRcd: SiPixelStatusScenarios_StuckTBMandOther_2023_v2_mc
    • Tags for D era (postBPix) and for cosmics:

      • SiPixelQualityFromDbRcd: SiPixelQuality_phase1_2023_v5_mc
      • SiPixelQualityFromDbRcd,forDigitizer: SiPixelQuality_forDigitizer_phase1_2023_v5_mc
      • SiPixelStatusScenarioProbabilityRcd: SiPixelQualityProbabilities_2023_v2_BPix_mc
      • SiPixelStatusScenariosRcd: SiPixelStatusScenarios_StuckTBMandOther_2023_v2_mc
    • CMS Talk post in https://cms-talk.web.cern.ch/t/new-pixel-status-scenarios-and-probabilities-for-2023-mc/28126

GT Differences:

PR validation:

Validated running:

runTheMatrix.py -s

Backport:

Corresponding updates for 13_2_X, 13_1_X, 13_0_X will be opened soon

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42601/36637

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta perrotta changed the title Update 132X MC Gts Update 2023 MC GTs Aug 18, 2023
@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff7906/34351/summary.html
COMMIT: b4600d4
CMSSW: CMSSW_13_3_X_2023-08-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42601/34351/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-sistrip_dqm_sourceclient had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.899 step 3
138.1 step 3
138.2 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4728 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152915
  • DQMHistoTests: Total failures: 4406
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3148487
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@tvami
Copy link
Contributor

tvami commented Aug 18, 2023

+alca

  • PR according to the desc
  • lot of diffs seen in the 2023 wfs, as expected due to re-digi of the new conditions
  • unit test failure is unrelated

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

+1

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit a31a679 into cms-sw:master Aug 18, 2023
@perrotta perrotta deleted the alca-update_132X_GTs branch August 18, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants