Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixelgpu online DQM client and augment DQM/Integration unit tests #42542

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 11, 2023

PR description:

This PR is a follow-up to my previous PR #41939 and to the TSG ticket https://its.cern.ch/jira/browse/CMSHLT-2846.
The main goal is to add DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.py: a new DQM online client designed to monitor the GPU and CPU Pixel collections from within the streamDQMGPUvsCPU stream.
At the moment only the SiPixelRawDataError collections are monitored by SiPixelPhase1RawDataErrorComparator, but in future, once more event products could be persisted after the ongoing alpaka migration, also other clients that are currently run within the HLT menu itself could be moved here.
I profit of this PR to include the new GPUVsCPU client (and the two existing ECAL and HCAL ones) in the battery of unit tests.
For data a corresponding PR to cms-data has been created (cms-data/DQM-Integration#4) in order to supply the necessary input files (albeit - alas - these files lack the proper pixel collections (SiPixelRawDataErroredmDetSetVector_hltSiPixelDigisFromSoA_*_* and SiPixelRawDataErroredmDetSetVector_hltSiPixelDigisLegacy_*_*) that became available after CMSHLT-2846 was closed).

PR validation:

Run successfully:

scram b runtests_TestDQMOnlineClient-ecalgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-hcalgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but to be backported for deployment in 2023 data-taking.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42542/36555

  • This PR adds an extra 24KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2023

test parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/SiPixelHeterogeneous (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @rchatter, @wang0jin, @argiro, @fioriNTU, @thomreis, @jandrea, @idebruyn, @threus, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34226/summary.html
COMMIT: 56c6da4
CMSSW: CMSSW_13_3_X_2023-08-10-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42542/34226/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34226/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34226/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150916
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2023

please test

  • even though unit tests passed OK

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34248/summary.html
COMMIT: 56c6da4
CMSSW: CMSSW_13_3_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42542/34248/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34248/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34248/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150945
  • DQMHistoTests: Total failures: 2611
  • DQMHistoTests: Total nulls: 134
  • DQMHistoTests: Total successes: 3148178
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 548.184 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 196.482 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12434.0,... ): 51.651 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): 25.958 KiB HLT/Filters
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Aug 15, 2023

@cms-sw/dqm-l2 could you please have a look to this one and corresponding cms-data/DQM-Integration#4 ?

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants