-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixelgpu
online DQM client and augment DQM/Integration unit tests
#42542
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42542/36555
|
test parameters: |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ba67/34248/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@cms-sw/dqm-l2 could you please have a look to this one and corresponding cms-data/DQM-Integration#4 ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up to my previous PR #41939 and to the TSG ticket https://its.cern.ch/jira/browse/CMSHLT-2846.
The main goal is to add
DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.py
: a new DQM online client designed to monitor the GPU and CPU Pixel collections from within thestreamDQMGPUvsCPU
stream.At the moment only the
SiPixelRawDataError
collections are monitored bySiPixelPhase1RawDataErrorComparator
, but in future, once more event products could be persisted after the ongoingalpaka
migration, also other clients that are currently run within the HLT menu itself could be moved here.I profit of this PR to include the new GPUVsCPU client (and the two existing ECAL and HCAL ones) in the battery of unit tests.
For data a corresponding PR to
cms-data
has been created (cms-data/DQM-Integration#4) in order to supply the necessary input files (albeit - alas - these files lack the proper pixel collections (SiPixelRawDataErroredmDetSetVector_hltSiPixelDigisFromSoA_*_*
andSiPixelRawDataErroredmDetSetVector_hltSiPixelDigisLegacy_*_*
) that became available after CMSHLT-2846 was closed).PR validation:
Run successfully:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but to be backported for deployment in 2023 data-taking.