Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQM-Integration streamer files for streamDQMGPUvsCPU #4

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 11, 2023

This PR:

As stated in cms-sw/cmssw#42542 unfortunately the streamer files for run369956 lack the necessary collections for the Pixel monitoring client (SiPixelRawDataErroredmDetSetVector_hltSiPixelDigisFromSoA_*_* and SiPixelRawDataErroredmDetSetVector_hltSiPixelDigisLegacy_*_*). I will update this repository later once we have an appropriate set of files from the central DQM team.

Cc: @francescobrivio

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for branch main.

@smuzaffar, @nothingface0, @aandvalenzuela, @emanueleusai, @iarspider, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

Looks good to me, thanks Marco!
No objection from my side to remove the unused streamDQMOnlineBeamspot streamer files for run346373.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78caef/34235/summary.html
COMMIT: 0048ac1
CMSSW: CMSSW_13_3_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/4/34235/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 19 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 30
  • DQMHistoTests: Total successes: 3150892
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link

+1

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit 36375e8 into cms-data:main Aug 15, 2023
@mmusich mmusich deleted the updateDQM-Integration_streamerFiles branch August 15, 2023 15:10
perrotta added a commit to cms-sw/cmsdist that referenced this pull request Aug 17, 2023
Move DQM-Integration data to new tag also in 13_2_X, see
cms-data/DQM-Integration#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants