MTD Validation: add histograms for detailed material budget vs eta study

[fabiocos]

PR description:

This PR adds a few histograms to the MTD specific class of Validation/Geometry for specialized checks in BTL and ETL separately, beyond the basic material budget plots vs eta and phi.

PR validation:

The desired histograms are correctly produced, in particular I attach the output for 20234:

MB_along_z_neutrinos_2D.pdf

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42517/36525

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42517/36525/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42517/36525/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42517/36529

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• Validation/Geometry (geometry, dqm)

@civanch, @Dr15Jones, @makortel, @nothingface0, @emanueleusai, @mdhildreth, @cmsbuild, @bsunanda, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vargasa, @rovere, @apsallid, @missirol, @rishabhCMS, @ebrondol, @rbartek this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42517/36533

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #42517 was updated. @civanch, @Dr15Jones, @makortel, @nothingface0, @emanueleusai, @mdhildreth, @cmsbuild, @bsunanda, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b5473/34186/summary.html
COMMIT: 2782c36
CMSSW: CMSSW_13_3_X_2023-08-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42517/34186/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 15 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150947
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150925
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

the error seems to be unrelated to the PR itself...

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b5473/34196/summary.html
COMMIT: 2782c36
CMSSW: CMSSW_13_3_X_2023-08-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42517/34196/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 201 lines to the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150947
• DQMHistoTests: Total failures: 281
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

the differences in the test seem unrelated to this PR, which is not affecting production workflows.

[civanch]

+1

what is strange (but unrelated to this PR): regression failures are spread over many WFs

[makortel]

what is strange (but unrelated to this PR): regression failures are spread over many WFs

It would be great if these seemingly random comparison differences would be reported in issues. These differences look similar to #42525, and I see

• the baseline tests were run on Intel(R) Xeon(R) CPU E5-2683 v4
• the PR tests were run on Intel(R) Xeon(R) Silver 4216 CPU

[emanueleusai]

+1

• spurious dqm differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1