CTPPS reco update to use LHCInfoPer* records

[Glitchmin]

Following LHCInfo update introducing 2 new records LHCInfoPerFill and LHCInfoPerLS (#39495) and their O2Os (#40817) this PR introduces:

• helper LHCInfoCombined class that is meant to be used where old LHCInfo was used
• every change needed to run recoCTPPS with only LHCInfoPer*

LHCInfoCombined can be created using either LHCInfoPer* or LHCInfo and is not meant to be serialised. It selects the source depending on the constructor parameter useNewLHCInfo that can be set based on era (since Run3 GTs won't contain LHCInfo records and Run2 GTs contain only those) in the python _cff file, eg.:

https://github.com/CTPPS/cmssw/blob/bb215fd85be7746ec3449516b4c0565aaf1f624f/CalibPPS/ESProducers/python/ctppsOpticalFunctions_cff.py#L32-L33

In order to make recoCTPPS able to use LHCInfoPer* or LHCInfo following modules were updated:

• CTPPSProtonProducer
• CTPPSInterpolatedOpticalFunctionsESSource

From PPS side this is the version of code meant to be used in re-reco of 2022 data.

PR validation:

Validation can be done by running recoCTPPS for fill 9019:

cd Calibration/PPSAlCaRecoProducer/test
cmsRun 2023_lhcinfo_test_recoCTPPS_cfg.py

and checking if h_multiplicity, h_xi and p_th_y_vs_xi for singleRP plots in alcareco_protons_express.root are not empty.

Additionally it was tested by comparing the aformentioned plots with the same plots generated with the code before changes from this PR. To generate plots for code before changes 2023_lhcinfo_test_recoCTPPS_cfg.py was copied and run with a tag with properly generated LHCInfo payloads for fill 9019 ( 130X_dataRun3_Prompt_forLHCInfo_Candidate_2023_07_28_12_52_37 )

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42515/36521

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibPPS/ESProducers/python/ctppsLHCInfo_cff.py modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File CondFormats/RunInfo/BuildFile.xml modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/interface/ProtonReconstructionAlgorithm.h modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/plugins/CTPPSProtonProducer.cc modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/python/ctppsProtons_cff.py modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/src/ProtonReconstructionAlgorithm.cc modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686

[cmsbuild]

A new Pull Request was created by @Glitchmin (Adam Kulczycki) for master.

It involves the following packages:

• CalibPPS/ESProducers (alca)
• Calibration/PPSAlCaRecoProducer (alca)
• CondFormats/DataRecord (db, alca)
• CondFormats/RunInfo (db, alca)
• CondTools/RunInfo (db)
• RecoPPS/ProtonReconstruction (reconstruction)

@perrotta, @consuegs, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @tocheng, @missirol, @grzanka, @mmusich, @forthommel, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42515/36522

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibPPS/ESProducers/python/ctppsLHCInfo_cff.py modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File CondFormats/RunInfo/BuildFile.xml modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/interface/ProtonReconstructionAlgorithm.h modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/plugins/CTPPSProtonProducer.cc modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/python/ctppsProtons_cff.py modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686
  • File RecoPPS/ProtonReconstruction/src/ProtonReconstructionAlgorithm.cc modified in PR(s): PPS proton reco update to use new LHCInfoPer* records #39686

[cmsbuild]

Pull request #42515 was updated. @perrotta, @consuegs, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d35760/34176/summary.html
COMMIT: 683ff19
CMSSW: CMSSW_13_3_X_2023-08-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42515/34176/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[Glitchmin]

I added a commit addressing build warnings, this commit will be squashed once the reviewing is done

[mandrenguyen]

+1

[Glitchmin]

From my side I'm not planning any more updates, I'm looking forward to more comments or approval

[perrotta]

+alca

[perrotta]

+db

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1