Ak update validity behaviour proton reco #80
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
PR containing suggested changes regarding reconstruction error behaviour:
LHCInterpolatedOpticalFunctionsSetCollection
if there is only one optical funtion and its xangle was different from the one in LHCInfoPR validation:
To see the first case please replace the if statement in lines 178 & 422 to if(true) in file ProtonReconstructionAlgorithm.cc
To see the second case replace line 73 in CTPPSInterpolatedOpticalFunctionsESSource.cc to
After that run the reco, for example using the file
RecoPPS/Local/test/2023_lhcinfo_test_recoCTPPS_cfg.py
from cms-sw#42515