Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ak update validity behaviour proton reco #80

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Glitchmin
Copy link

PR description:

PR containing suggested changes regarding reconstruction error behaviour:

  • retuning invalid proton (not visible on the plots) if optics for a given track are not available
  • returning empty LHCInterpolatedOpticalFunctionsSetCollection if there is only one optical funtion and its xangle was different from the one in LHCInfo

PR validation:

  • To see the first case please replace the if statement in lines 178 & 422 to if(true) in file ProtonReconstructionAlgorithm.cc

  • To see the second case replace line 73 in CTPPSInterpolatedOpticalFunctionsESSource.cc to

  LHCOpticalFunctionsSetCollection const &ofColl2 = iRecord.get(opticsToken_);
  auto ofColl = ofColl2;
  auto it = ofColl.begin();
  while (ofColl.size()>1) {
      it = ofColl.erase(it);
  }

After that run the reco, for example using the file RecoPPS/Local/test/2023_lhcinfo_test_recoCTPPS_cfg.py from cms-sw#42515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant