Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] update HLTPPSJetComparisonFilter to use LHCInfoCombined #43954

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 13, 2024

backport of #43951

PR description:

This PR updates HLTPPSJetComparisonFilter to be able to use both old LHCInfo (for Run 2 & Direct Simulation calculations) and new LHCInfoPer* records (Run 3) record types. The update is a follow-up to #42515 and #42890

PR validation:

Private TSG tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43951

@mmusich
Copy link
Contributor Author

mmusich commented Feb 13, 2024

type ctpps

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2024

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/special (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 13, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae181d/37430/summary.html
COMMIT: 24db394
CMSSW: CMSSW_14_0_X_2024-02-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43954/37430/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 14, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Feb 14, 2024

urgent

  • for 14_0_0, to be parsed in confDB for trigger development

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2fa7299 into cms-sw:CMSSW_14_0_X Feb 15, 2024
10 checks passed
@mmusich mmusich deleted the ak_update_HLTPPSJetComparisonFilter_14_0_X branch February 15, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants