[13_1_X] Change muon shower BX assignment in EMTF

[eyigitba]

PR description:

This PR changes the BX range for muon showers in ETMF emulator. In #38941 BX assignment for muon showers in CSC unpacking/emulation changed, but the corresponding changes were not don in EMTF.

This PR also follows the same convention used in #41993, so the emulated and unpacked showers should now be aligned as it should be.

This is a backport of #42176

I don't know which release will be used when LHC restarts, but this backport might be necessary for some re-emulation studies with 2023 data.

PR validation:

Tested with L1T menu experts to see unpacked/emulated shower matches. Also validated by runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

FYI @caruta @elfontan

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_13_1_X.

It involves the following packages:

• L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @JanFSchulte, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Change muon shower BX assignment in EMTF #42176

[aloeliger]

backport of #42176

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f78a77/33804/summary.html
COMMIT: d479301
CMSSW: CMSSW_13_1_X_2023-07-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42322/33804/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 12 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193363
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193334
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

@eyigitba Is this dependent on having backported the fix to bx-vectors in #42214 ? Would you like me to prepare a backport of that for these PRs to run with?

[eyigitba]

Hi @aloeliger yes, that should also be backported along with this. I forgot about that. Thanks for reminding

[aloeliger]

please test with #42330

[aloeliger]

Hi @aloeliger yes, that should also be backported along with this. I forgot about that. Thanks for reminding

@eyigitba Okay. I have two backport PRs open for the BX vector issue. Shouldn't be an issue.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f78a77/33825/summary.html
COMMIT: d479301
CMSSW: CMSSW_13_1_X_2023-07-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42322/33825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3186945
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3186909
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1