[13_1_X] Add BX boundary checks for BXVector push_back

[aloeliger]

PR description:

Original description:

Quick fix requested in #42185. This includes a check in BXVector::push_back that only includes the data if it is between bxFirst_ and bxLast_, a LogWarning with some info is issued otherwise (I could remove that if complicating the buildfile and includes is undesirable).

backported for #42322

PR validation:

Original PR has been tested to solve several issues

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42214

[aloeliger]

Backport of #42214

[cmsbuild]

A new Pull Request was created by @aloeliger (Andrew Loeliger) for CMSSW_13_1_X.

It involves the following packages:

• DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @eyigitba, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add BX boundary checks for BXVector push_back #42214

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72d61b/33824/summary.html
COMMIT: d73c248
CMSSW: CMSSW_13_1_X_2023-07-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42330/33824/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3186945
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3186920
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1