-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13_0_X] Prevent producing EMTFTrack if only muon shower was unpacked #42319
[13_0_X] Prevent producing EMTFTrack if only muon shower was unpacked #42319
Conversation
A new Pull Request was created by @eyigitba for CMSSW_13_0_X. It involves the following packages:
@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #42172 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10ca9d/33801/summary.html Comparison SummarySummary:
|
@aloeliger , same answer as well. We should backport that PR too
|
Ahh, I put this on the wrong PR, this is not an issue for this PR, but for #42321. In any case, the BX vector check fix is backported and going through tests now, so this PR should be fine. |
+l1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
and I also responded without checking the PR :). You're right it's related to the other one |
+1
|
PR description:
This is a quick PR to fix something I missed in #41993. I should have made it so that no EMTFTrack is produced for muon shower only DAQ blocks. Now this is fixed.
This is a backport of #42172
I don't know which release will be used when LHC restarts, but this backport might be necessary for some re-emulation studies with 2023 data.
PR validation:
Validated by running on recent data, behaves expectedly.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: