Run3-hcx348 Try to address the issues of ieta=18 and ieta=15 towers in layer=2 of HCAL

[bsunanda]

PR description:

Try to address the issues of ieta=18 and ieta=15 towers in layer=2 of HCAL. Thanks to Salavat who provided a useful tool for testing

PR validation:

Use the runTheMatrix test workflows and the script runHcalHitRebeller_cf.py in SimG4CMS/Calo/test/python (due to Salavat)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a bug fix and may need to be back ported to 13_0_X and 13_1_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42130/36109

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42130/36109/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42130/36109/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

Tyoe Bug-Fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42130/36110

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HcalCommonData (geometry)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @wang0jin, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[abdoulline]

Thanks! Let me try to check it with my test...

[abdoulline]

Thank you, Sunanda.
Tested in CMSSW_13_2_X_2023-06-28-2300 (with 2 previous PRs with fixes merged in) - none of previously reported issues spotted anymore.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd04a2/33442/summary.html
COMMIT: 4591480
CMSSW: CMSSW_13_2_X_2023-06-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42130/33442/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 108 lines from the logs
• Reco comparison results: 37651 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193832
• DQMHistoTests: Total failures: 58065
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3135744
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.21300000000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.371 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -0.047 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.111 KiB SiStrip/MechanicalView
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[civanch]

@bsunanda , the change '(int) -> static_cast' has nothing to do with the problem. I would do this in different PR not mixing with the bug-fix. Moreover, I am not sure if this will be required in C++20, having C-cast may be OK.

[bsunanda]

@civanch That is true. So the back porting includes only one file. I am removing them from the list. Can you please sign this now?

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42130/36150

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #42130 was updated. @makortel, @bsunanda, @civanch, @Dr15Jones, @mdhildreth can you please check and sign again.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd04a2/33479/summary.html
COMMIT: 08f8c4a
CMSSW: CMSSW_13_2_X_2023-06-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42130/33479/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 87 lines from the logs
• Reco comparison results: 37652 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193832
• DQMHistoTests: Total failures: 58065
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3135744
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.21300000000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.371 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -0.047 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.111 KiB SiStrip/MechanicalView
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[perrotta]

+1