Run3-hcx349 Fix the remaining issue of ieta=18 and ieta=15 towers in layer=2 of HCAL - backport of #42130to CMSSW version 13_1_X

[bsunanda]

PR description:

Fix the remaining issue of ieta=18 and ieta=15 towers in layer=2 of HCAL - backport of #42130to CMSSW version 13_1_X. This is a backport of #42130

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #42130 to CMSSW version 13_1_X

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_1_X.

It involves the following packages:

• Geometry/HcalCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c866d/33443/summary.html
COMMIT: 7d73be1
CMSSW: CMSSW_13_1_X_2023-06-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42134/33443/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 85 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 37241 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3222811
• DQMHistoTests: Total failures: 61159
• DQMHistoTests: Total nulls: 18
• DQMHistoTests: Total successes: 3161612
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -6.596 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -5.717 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.527 KiB SiStrip/MechanicalView
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c866d/33476/summary.html
COMMIT: 7d73be1
CMSSW: CMSSW_13_1_X_2023-06-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42134/33476/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 100 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 37242 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3222811
• DQMHistoTests: Total failures: 61224
• DQMHistoTests: Total nulls: 18
• DQMHistoTests: Total successes: 3161547
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -6.596 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -5.717 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.527 KiB SiStrip/MechanicalView
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of the modifications in HcalHitRelabeller.cc from Run3-hcx348 Try to address the issues of ieta=18 and ieta=15 towers in layer=2 of HCAL #42130. The test script is not backported
• Tests are now massively failing in the IBs, for unrelated reasons; however they succeeded at least once in master after the merging of Run3-hcx348 Try to address the issues of ieta=18 and ieta=15 towers in layer=2 of HCAL #42130