Run3-hcx350 Fix the remaining issue of ieta=18 and ieta=15 towers in layer=2 of HCAL - backport of #42130 to CMSSW version 13_0_X

[bsunanda]

PR description:

Fix the remaining issue of ieta=18 and ieta=15 towers in layer=2 of HCAL - backport of #42130 to CMSSW version 13_0_X. This is a backport of #42130 from the master

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #42130

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

• Geometry/HcalCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551845/33444/summary.html
COMMIT: 9ffef29
CMSSW: CMSSW_13_0_X_2023-06-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42135/33444/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially added 256 lines to the logs
• Reco comparison results: 38324 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3317136
• DQMHistoTests: Total failures: 54831
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3262277
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.066 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.598 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 2.074 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.410 KiB SiStrip/MechanicalView
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: found differences in 9 / 47 workflows

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551845/33483/summary.html
COMMIT: 9ffef29
CMSSW: CMSSW_13_0_X_2023-06-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42135/33483/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 247 lines to the logs
• Reco comparison results: 38323 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3317136
• DQMHistoTests: Total failures: 54832
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3262276
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.066 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.598 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 2.074 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.410 KiB SiStrip/MechanicalView
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: found differences in 9 / 47 workflows

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of the modifications in HcalHitRelabeller.cc from Run3-hcx348 Try to address the issues of ieta=18 and ieta=15 towers in layer=2 of HCAL #42130. The test script is not backported
• Tests are now massively failing in the IBs, for unrelated reasons; however they succeeded at least once in master after the merging of Run3-hcx348 Try to address the issues of ieta=18 and ieta=15 towers in layer=2 of HCAL #42130