Add ECal-component modifiers and test workflows

[srimanob]

PR description:

This PR adds modifiers ecal_component and ecal_component_finely_sampled_waveforms to avoid long customization, and add test workflows .631 and .632.

The customization comes from this link.

PR validation:

Test with 20834.631 and 20834.632.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport, or we can backport to 13_0 if it makes cmsDriver look more cleaner in production.

[srimanob]

test parameters:

• workflows = 20834.631,20834.632
• relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42097/36078

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2  #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, More Configurable Pixel Tracks and HIon Template #41632, Add run3 tracking low pu era #33532, Enable .59521 and .59621 wfs for profiling #42061

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• Configuration/ProcessModifiers (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• SimCalorimetry/EcalSimProducers (simulation)
• SimG4Core/Application (simulation)

@perrotta, @rappoccio, @bbilin, @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @sunilUIET, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@missirol, @rchatter, @makortel, @kpedro88, @argiro, @Martin-Grunewald, @bsunanda, @rovere, @thomreis, @wang0jin, @sameasy, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[srimanob]

type ecal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-debe27/33396/summary.html
COMMIT: 5054bcd
CMSSW: CMSSW_13_2_X_2023-06-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42097/33396/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 32 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

It seems that this PR simplifies configuration.

[srimanob]

+Upgrade

The workflow need to be modified in follow-up PR, but this PR can be merged first, so that ECAL will have workflow to test and to develop.

[srimanob]

Ping @cms-sw/pdmv-l2

[jhakala]

What's the status on this PR?

As an aside, this looks like we are only implementing the workflows for the component method for Phase-II so far. However, it might be worth it to have workflows and simulated samples that have the component method for Phase-I as well, as a validation of the method (as recommended by Sasha Ledovskoy). So if this is stalled awaiting unrelated Phase-II ECAL developments, then maybe things could progress by using the component method for Phase-I instead.

[sunilUIET]

+pdmv

[srimanob]

@cmsbuild please test

Retest after a week before merging.

[srimanob]

What's the status on this PR?

As an aside, this looks like we are only implementing the workflows for the component method for Phase-II so far. However, it might be worth it to have workflows and simulated samples that have the component method for Phase-I as well, as a validation of the method (as recommended by Sasha Ledovskoy). So if this is stalled awaiting unrelated Phase-II ECAL developments, then maybe things could progress by using the component method for Phase-I instead.

Hi @jhakala
Thanks for the reminder of trying on Run-3. I agree that we should merge this PR and try to have a test on it.
@perrotta @rappoccio Do we have a chance to merge this configuration PR to 13_3_0_pre3? Just to note, or if we need to wait for 13_3, it is fine too. Currently, this PR is waiting to refresh the test only. Thanks.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-debe27/33648/summary.html
COMMIT: 5054bcd
CMSSW: CMSSW_13_2_X_2023-07-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42097/33648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193867
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.