SIM: fixed scripts and mctruth

[civanch]

PR description:

Small inaccuracy in several MC python scripts are fixed. MC truth code is cleaned-up

It is not expected any change of results.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42223/36231

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • SimG4CMS/HcalTestBeam/test/python/TB2006Analysis_cfi.py:
    • Added: 79db293
    • Deleted: 6077f4d

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Add ECal-component modifiers and test workflows #42097

[civanch]

please test

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4CMS/HcalTestBeam (simulation)
• SimG4Core/Application (simulation)
• SimG4Core/Notification (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47a8c4/33615/summary.html
COMMIT: 591a0f6
CMSSW: CMSSW_13_2_X_2023-07-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42223/33615/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193861
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

again timeout

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@perrotta , @rappoccio , please, give me advice: timeout problem does not related to this PR. There may be two actions: 1) merge it neglecting this problem; 2) restart tests until they succeed. In the case 1) we save resources but likely the merge will be postponed or never happened. What is your point of view?

[perrotta]

@perrotta , @rappoccio , please, give me advice: timeout problem does not related to this PR. There may be two actions: 1) merge it neglecting this problem; 2) restart tests until they succeed. In the case 1) we save resources but likely the merge will be postponed or never happened. What is your point of view?

@civanch if it is clear that the issue with the RelVal tests is uncorrelated, and it does not hide possible problems which end up not being tested by the failing workflows, I don't see why why should keep trying and retrying to run those useless tests.
Unfortunately, those RelVals-Input timeout's are rather common, and if not relevant we can avoid loosing time and resources for it.

[perrotta]

+1

[perrotta]

merge