[13_0_X] Update L1T Menu tag for 2023/2024/Run4 in MC GTs

[francescobrivio]

PR description:

Backport of #41485

This PR updates the L1T Menu tag in the MC GTs for 2023/2024/Run4 to the latest available tag, i.e. L1Menu_Collisions2023_v1_1_0-v2_xml, as requested in this CMSTalk message.

In addition, the run3_[data|hlt]_relval symbolic GTs are updated as well with the same tag via the autoCondModifier L1TUtmTriggerMenuForRelValForRun3.

As per @missirol's request I also updated the same tag in Configuration/HLT/python/autoCondHLT.py

EDIT:
Following the request in this CMSTalk post we have also updated the HI MC GTs for 2022 and 2023 with the correct L1Menu tag (L1Menu_CollisionsHeavyIons2022_v1_1_0-d1_xml)

FYI @caruta

The GT differences are:

• 2022 realistic HI:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2022_realistic_HI_v4/130X_mcRun3_2022_realistic_HI_v5
• 2023 design:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023_design_v5/130X_mcRun3_2023_design_v6
• 2023 realistic:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023_realistic_v7/130X_mcRun3_2023_realistic_v8
• 2023 cosmic realistic:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023cosmics_realistic_deco_v6/130X_mcRun3_2023cosmics_realistic_deco_v7
• 2023 cosmic design:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023cosmics_design_deco_v5/130X_mcRun3_2023cosmics_design_deco_v6
• 2023 realistic HI:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023_realistic_HI_v12/130X_mcRun3_2023_realistic_HI_v14
• 2024 realistic:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2024_realistic_v5/130X_mcRun3_2024_realistic_v6
• Phase2 realistic:
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun4_realistic_v3/130X_mcRun4_realistic_v7

PR validation:

See master PR for the validation

Backport:

Backport of #41485

[francescobrivio]

backport of #41485

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_13_0_X.

It involves the following packages:

• Configuration/AlCa (alca)
• Configuration/HLT (hlt)

@Martin-Grunewald, @cmsbuild, @missirol, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@silviodonato, @tocheng, @Martin-Grunewald, @missirol, @mmusich, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Update L1T Menu tag for 2023/2024/Run4 in MC GTs #41485

[francescobrivio]

test parameters:

• workflows = 140.001,12434.0,12834.0,23234.0

[francescobrivio]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d576df/32314/summary.html
COMMIT: 6a4ddc3
CMSSW: CMSSW_13_0_X_2023-05-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41490/32314/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 140.56140.56_RunHI2018/step2_RunHI2018.log
• 1002.31002.3_RunZeroBias2022B/step2_RunZeroBias2022B.log
• 1002.41002.4_RunDoubleMuon2022B/step2_RunDoubleMuon2022B.log

Expand to see more relval errors ...

• 11834.13
• 12034.0
• 11846.0
• 20834.103
• 20834.75
• 21034.114

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3801601
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3801569
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 222 log files, 172 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

See #41485 (comment) (modulo the fact that, in the latter comment, the point about the HIon GT does not apply to 130X GTs).

The RelVals-INPUT error is assumed to be unrelated to this PR.

[cmsbuild]

Pull request #41490 was updated. @Martin-Grunewald, @cmsbuild, @missirol, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d576df/32347/summary.html
COMMIT: 679e0ff
CMSSW: CMSSW_13_0_X_2023-05-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41490/32347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 29 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3801601
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3801569
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.805 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -1.805 KiB L1T/L1TStage2uGT
• Checked 222 log files, 172 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[saumyaphor4252]

+alca

• workflows testing the GTs pass
• diffs in reco comparisons only for MsgLogger

[missirol]

+hlt

• The HLT changes are okay (and thanks for updating autoCondHLT.py).

• This PR is a prerequisite for integrating the next version of the 2023 HLT menu in a future PR in the next days (as that new HLT menu will require the L1T menu included here, i.e. 2023-v1_1_0).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

@saumyaphor4252 , just a reminder that HLT would also need a backport of #41485 to 13_1_X if master moves to 13_2_X before #41485 is merged.

[saumyaphor4252]

just a reminder that HLT would also need a backport of #41485 to 13_1_X if master moves to 13_2_X before #41485 is merged.

Thanks @missirol Duly Noted. The backport will be needed from AlCa POV too, in that case.

[perrotta]

• The tag versions in Confdb.py are newer (let say: higher version number) in this backport PR than in the master version of it: is it intended?
• The HI MC GTs for 2022 and 2023 where merged in master in some other PR? Please add the link in the PR description if so

[missirol]

@cms-sw/alca-l2 , any chance we could converge on this PR ? HLT needs it to integrate the next HLT menu.

[francescobrivio]

Sorry Marino the "confdb" (instead of "conddb") in the comment confused me so I forgot about it! I'll take a look immediately!

[francescobrivio]

Ciao @perrotta

• The tag versions in Confdb.py are newer (let say: higher version number) in this backport PR than in the master version of it: is it intended?

Yes, because here we are updating the 130X GTs, while in master we were updating the 131X GTs - so you can't really compare the version number of two different cycles. So this is a backport in the sense that we introduced the same conditions, but the autoCond file itself is different by construction because of the different GT names :)

* The HI MC GTs for 2022 and 2023 where merged in master in some other PR? Please add the link in the PR description if so

The HI MC GTs are being frequently updated following the requests from the HI group - there have a been a few updates that so far we included only in 125X and 131X (due to MC production plans), but now HI group requested to update also the 130X version of the GTs (the request is linked in the "EDIT" section of this PR description)

[perrotta]

Thank you @francescobrivio

So, the HI MC tags where already there in master (brought there by #41327). Let me point out that master was further updated for these GTs with #41437: is that something that we should also backport to 13_0_X?

[francescobrivio]

Let me point out that master was further updated for these GTs with #41437: is that something that we should also backport to 13_0_X?

Thanks Andrea for this! We'll inquire with HI experts if it's needed or not.
For the moment it's definitely not urgent - so I suggest we merge this PR which is indeed urgent for HLT and we can eventually followup with another PR for HI only if needed.

EDIT: Being followed up here

[perrotta]

+1

• Backport of Update L1T Menu tag for 2023/2024/Run4 in MC GTs #41485 and Include HcalPFCuts Rcd and update SiPixel Dynamic Inefficiency tags in MC GTs #41327
• Update L1TCaloParams in 2022 and 2023 HI MC GTs #41437 still needs to be backported (if ever needed)

[saumyaphor4252]

The backport is done in #41567 and #41440.