Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update L1T Menu tag for 2023/2024/Run4 in MC GTs #41485

Merged
merged 3 commits into from
May 3, 2023
Merged

Update L1T Menu tag for 2023/2024/Run4 in MC GTs #41485

merged 3 commits into from
May 3, 2023

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented May 2, 2023 •
edited
Loading

PR description:

This PR updates the L1T Menu tag in the MC GTs for 2023/2024/Run4 to the latest available tag, i.e. L1Menu_Collisions2023_v1_1_0-v2_xml, as requested in this CMSTalk message.

In addition, the run3_[data|hlt]_relval symbolic GTs are updated as well with the same tag via the autoCondModifier L1TUtmTriggerMenuForRelValForRun3.

EDIT:
As per @missirol's request I also updated the same tag in Configuration/HLT/python/autoCondHLT.py

FYI @caruta

The GT differences are:

PR validation:

Successfully tested with
runTheMatrix.py -l 140.001,160.0,12434.0,12834.0,23234.0 -j 8 --ibeos

Backport:

Not a backport, but a 130X backport will be provided soon.

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone May 2, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41485/35350

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows = 140.001,160.0,12434.0,12834.0,23234.0

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@missirol
Copy link
Contributor

missirol commented May 2, 2023

@francescobrivio , thanks for the PR. I would like to ask a favor, in order to minimise PRs (and backports).

Could you please update autoCondHLT.py here as follows ?

-    'FULL'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0_xml'                        ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-04-26 12:17:38.000"] ), ),
-    'GRun'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0_xml'                        ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-04-26 12:17:38.000"] ), ),
+    'FULL'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0-v2_xml'                     ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-05-02 08:03:44.000"] ), ),
+    'GRun'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0-v2_xml'                     ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-05-02 08:03:44.000"] ), ),

@francescobrivio
Copy link
Contributor Author

@francescobrivio , thanks for the PR. I would like to ask a favor, in order to minimise PRs (and backports).

Could you please update autoCondHLT.py here as follows ?

-    'FULL'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0_xml'                        ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-04-26 12:17:38.000"] ), ),
-    'GRun'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0_xml'                        ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-04-26 12:17:38.000"] ), ),
+    'FULL'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0-v2_xml'                     ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-05-02 08:03:44.000"] ), ),
+    'GRun'         : ( ','.join( [ 'L1Menu_Collisions2023_v1_1_0-v2_xml'                     ,l1tMenuRecord,connectionString,l1tMenuLabel, "2023-05-02 08:03:44.000"] ), ),

Ciao @missirol, sure no problem!
Just two questions:

  1. Is there a specific reason to use "2023-05-02 08:03:44.000" as you suggest? Or "my" "2023-05-02 12:00:00.000" works also for you?
  2. This change should be applied to the 130X backport (coming soon) as well, correct?

@francescobrivio
Copy link
Contributor Author

@cmsbuild please abort

@francescobrivio francescobrivio force-pushed the alca-L1T_menu_2023_13_1_X branch from 8e93cbb to d6565cd Compare May 2, 2023 14:41
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41485/35356

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

Pull request #41485 was updated. @Martin-Grunewald, @cmsbuild, @missirol, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

@missirol
Copy link
Contributor

missirol commented May 2, 2023 •
edited
Loading

  1. Is there a specific reason to use "2023-05-02 08:03:44.000" as you suggest? Or "my" "2023-05-02 12:00:00.000" works also for you?

We usually put the exact timestamp of the tag in the db. This practise predates me, and I admit I don't know if it has any practical implications. If you don't disagree, I suggest to simply follow this practise for autoCondHLT.py (exact timestamp).

  1. This change should be applied to the 130X backport (coming soon) as well, correct?

Correct.

@francescobrivio
Copy link
Contributor Author

If you don't disagree, I suggest to simply follow this practise for autoCondHLT.py (exact timestamp).

IIUC, as long as the timestamp is after the tag creation it should be fine, but sure I can follow the HLT convention - I will force-push the change in few minutes.

@cmsbuild cmsbuild mentioned this pull request May 3, 2023
Merged
@francescobrivio
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label May 3, 2023
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41485/35367

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

Pull request #41485 was updated. @Martin-Grunewald, @missirol, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d68d5d/32330/summary.html
COMMIT: c163571
CMSSW: CMSSW_13_1_X_2023-05-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41485/32330/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3806333
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3806307
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 221 log files, 171 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented May 3, 2023

+hlt

  • The HLT changes are okay (and thanks for updating autoCondHLT.py).

  • This PR is a prerequisite for integrating the next version of the 2023 HLT menu in a future PR in the next days (as that new HLT menu will require the L1T menu included here, i.e. 2023-v1_1_0).

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 3, 2023

+1

  • Let have this merged before moving the master to 13_1_X, so that we can avoid one backport

@cmsbuild cmsbuild merged commit cdf6fec into cms-sw:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@francescobrivio @cmsbuild @missirol @saumyaphor4252 @perrotta