Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1TCaloParams in 2022 and 2023 HI MC GTs #41437

Merged

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Apr 27, 2023

PR description:

This PR updates the 2022 and 2023 realsitic HI MC GTs with the following latest L1TCaloParams tags, respectively:

  • L1TCaloParams_static_HI_2022_v0_05_mc_v1
  • L1TCaloParams_static_HI_2022_v0_06_mc_v1

as requested in this CMS Talk post [1].

[1] https://cms-talk.web.cern.ch/t/request-for-new-hi-mc-gts-with-updated-l1-parameters-for-heavy-ions-for-125x-and-131x/23153

GT Differences with the last ones are here:

PR validation:

GTs tested locally with runTheMatrix.py -l 159.1,160.1 -j 10 --ibeos which consume auto:phase1_2022_realistic_hi and auto:phase1_2023_realistic_hi keys

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. A backport will be followed up in 130X for 2023 HI MC GT.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41437/35303

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@francescobrivio
Copy link
Contributor

The errors in the tests are due to the fact that the new tags for MC don't have the correct IOV (i.e. IOV != 1), see:

We need to remake the tags with the proper IOV.

@francescobrivio
Copy link
Contributor

@cmsbuild please abort

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41437/35306

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #41437 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d8d0c/32201/summary.html
COMMIT: 3fa6175
CMSSW: CMSSW_13_1_X_2023-04-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41437/32201/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460685
  • DQMHistoTests: Total failures: 65
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • A few differences in the L1T directories of 312.0 which is the HI 2022 workflow - so I'd say that's expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants