[GEM] DataFormat Bugfix - remove unused bits from VFat dataformat

[jshlee]

PR description:

Urgent bugfix for GEM dataformat needed for current FW.
VFat position uses 5 bits but was set to 8 since the other 3 was unused.
However, this creates invalid vfats in current data due to the unused bits not always being 0.
This was found from http://cmsonline.cern.ch/cms-elog/1178749.

PR validation:

Tested with wf 11611.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This will need to be backported asap to 13_0

@watson-ij @yeckang

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41384/35249

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

• DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@missirol, @eyigitba, @rovere, @watson-ij, @giovanni-mocellin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[jshlee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b5db4/32088/summary.html
COMMIT: 5d493e1
CMSSW: CMSSW_13_1_X_2023-04-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41384/32088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 16 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460915
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460887
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[AdrianoDee]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

@jshlee please prepare the backport for 13_0_X
It missed currently building 13_0_4 (as nobody requested it urgently at the last ORP meeting), but it can enter next (patch) release