[GEM] DataFormat Bugfix - remove unused bits from VFat dataformat - backport of #41384

[jshlee]

PR description:

Urgent bugfix for GEM dataformat needed for current FW.
VFat position uses 5 bits but was set to 8 since the other 3 was unused.
However, this creates invalid vfats in current data due to the unused bits not always being 0.
This was found from http://cmsonline.cern.ch/cms-elog/1178749.

PR validation:

Tested with wf 11611.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #41384

@watson-ij @yeckang

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_13_0_X.

It involves the following packages:

• DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@missirol, @eyigitba, @rovere, @watson-ij, @giovanni-mocellin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from [GEM] DataFormat Bugfix - remove unused bits from VFat dataformat #41384

[jshlee]

please test

[perrotta]

backport of #41384

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b0959/32196/summary.html
COMMIT: ee62d8d
CMSSW: CMSSW_13_0_X_2023-04-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41443/32196/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554298
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554269
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1