Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (7/N) [13_1_X] #41387

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following JIRA tickets.

  • CMSHLT-2720: [TSG] seed DQMGPUvsCPU triggers of GRun with all L1A-Physics events
  • CMSHLT-2733: [HCAL] increased HLT PSs of IsoTrack(HB,HE) triggers by 3
  • CMSHLT-2736: [TSG] remove SCAL unpacker from Run-3 HLT menus
  • CMSHLT-2737: [TSG] add L1_SingleEG4* seeds to single-EG Scouting trigger
  • CMSHLT-2741: [ECAL] removal of Ele36*_noEoP* trigger
  • CMSHLT-2746: [TSG] separate Scouting triggers seeded by L1_DoubleMu and L1_(HTT,*Jet)
  • CMSHLT-2751: [HIG] remove MSSM-Hbb triggers using DeepCSV
  • CMSHLT-2752: [TSG] updated HLT PSs of *PFJet(140,200) in low-lumi columns
  • CMSHLT-2753: [HIG] remove HLT_SingleJet30_Mu12_SinglePFJet40_v trigger
  • CMSHLT-2755: [TSG] added L1_DoubleJet30er2p5_Mass_Min250_dEta_Max1p5 seed to Scouting
  • CMSHLT-2758: [ECAL] remove *LowPU products from EventContent of ALCAP0 stream

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_0_X

Development of HLT menus for `CMSSW_13_0_X`.

This update includes the integration of the following JIRA tickets.

 - [CMSHLT-2720](https://its.cern.ch/jira/browse/CMSHLT-2720): [TSG] seed `DQMGPUvsCPU` triggers of GRun with all L1A-Physics events
 - [CMSHLT-2733](https://its.cern.ch/jira/browse/CMSHLT-2733): [HCAL] increased HLT PSs of `IsoTrack(HB,HE)` triggers by 3
 - [CMSHLT-2736](https://its.cern.ch/jira/browse/CMSHLT-2736): [TSG] remove SCAL unpacker from Run-3 HLT menus
 - [CMSHLT-2737](https://its.cern.ch/jira/browse/CMSHLT-2737): [TSG] add `L1_SingleEG4*` seeds to single-EG Scouting trigger
 - [CMSHLT-2741](https://its.cern.ch/jira/browse/CMSHLT-2741): [ECAL] removal of `Ele36*_noEoP*` trigger
 - [CMSHLT-2746](https://its.cern.ch/jira/browse/CMSHLT-2746): [TSG] separate Scouting triggers seeded by `L1_DoubleMu` and `L1_(HTT,*Jet)`
 - [CMSHLT-2751](https://its.cern.ch/jira/browse/CMSHLT-2751): [HIG] remove MSSM-Hbb triggers using DeepCSV
 - [CMSHLT-2752](https://its.cern.ch/jira/browse/CMSHLT-2752): [TSG] updated HLT PSs of `*PFJet(140,200)` in low-lumi columns
 - [CMSHLT-2753](https://its.cern.ch/jira/browse/CMSHLT-2753): [HIG] remove `HLT_SingleJet30_Mu12_SinglePFJet40_v` trigger
 - [CMSHLT-2755](https://its.cern.ch/jira/browse/CMSHLT-2755): [TSG] added `L1_DoubleJet30er2p5_Mass_Min250_dEta_Max1p5` seed to Scouting
 - [CMSHLT-2758](https://its.cern.ch/jira/browse/CMSHLT-2758): [ECAL] remove `*LowPU` products from EventContent of ALCAP0 stream
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41387/35254

  • This PR adds an extra 716KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • enable = gpu
  • workflows_gpu = 12434.506,12434.512,12434.522,140.065506,140.065512,140.065522

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dd6ca/32096/summary.html
COMMIT: 4f09e32
CMSSW: CMSSW_13_1_X_2023-04-23-0000/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41387/32096/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460683
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3460649
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -53.632 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -25.961 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): -0.855 KiB HLT/Filters
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

GPU Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 10
  • DQMHistoTests: Total histograms compared: 44638
  • DQMHistoTests: Total failures: 930
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 43708
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 9 files compared)
  • Checked 36 log files, 27 edm output root files, 10 DQM output files
  • TriggerResults: found differences in 6 / 9 workflows

@missirol
Copy link
Contributor Author

Maybe it's just me, but I cannot see the DQM bin-by-bin comparisons in cmsweb.cern.ch/dqm. The symptoms are similar to #38980.

I see the issue in other PRs as well. It looks like it started yesterday: I can see plots as usual up to #41384 (comment) (Apr 22, 05:08), while they do not appear for me starting from #41385 (comment) (Apr 22, 16:45).

@cms-sw/dqm-l2, could you please have a look ?

@missirol
Copy link
Contributor Author

missirol commented Apr 23, 2023

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 79a91f3 into cms-sw:master Apr 23, 2023
@missirol missirol deleted the HLTdevelopment130X_for131X branch April 26, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants