-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport codes for adding new data catalogs from Rucio storage description (RucioCatalog) and use it by default instead of trivial data catalogs (TrivialCatalog) #37278, and related bug fixes #41309
Conversation
…ge.json (transition to Rucio)
A new Pull Request was created by @nhduongvn for CMSSW_12_5_X. It involves the following packages:
@smuzaffar, @Dr15Jones, @makortel, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@nhduongvn please explain the rationale for a backport for this very old feature to be back ported to 12_5? |
The motivation was outlined in #37278 (comment) (quoting @stlammel)
|
Yes, there was a plan to backport this "old" feature to previous releases (up to 12_5_X if I remember correctly). I have done it now so that the feature can be fully tested and following up fixes can be included. It looks to me things are OK now and I will continue to backport to other releases. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73c960/31911/summary.html Comparison SummarySummary:
|
Actually these should go back to "all actively used release cycles". Defining this set of release cycles has been challenging in the past, partially because we tend to keep release cycles open in the IBs longer than they are actually being used (because figuring out what is actually being used is not that easy). Maybe a reasonable starting point would be (in addition of this PR, and 12_6_X and 13_0_X that need only #40961)
For the other release cycles (10_2_X, 10_3_X, 11_0_X, 11_1_X, 11_2_X, 11_3_X, 12_0_X, 12_1_X) we (@cms-sw/orp-l2 @cms-sw/pdmv-l2) should figure out if they still need to be kept open or could be closed. For those that need to be kept open (for, say, more than a year), the Rucio catalog should backported to them. 5_3_X (Run 1 legacy) we can probably leave out |
Comparison differences in workflows 39496.0 and 39500.0 seem point to an old issue #39214 |
+core The commits diffs are identical to the original PRs |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport to 12_5_X:
#37278
#39314
#39727
#40961