Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail comparison of the empty simPVZ (MTD vertices) in PR test #39214

Closed
srimanob opened this issue Aug 26, 2022 · 13 comments
Closed

Fail comparison of the empty simPVZ (MTD vertices) in PR test #39214

srimanob opened this issue Aug 26, 2022 · 13 comments

Comments

@srimanob
Copy link
Contributor

This issue is to follow the issue of always fail comparison of the empty simPVZ histogram under MTD vertices.

FYI @fabiocos @perrotta I think we did have a short discussion on this before but I can't find it. We can close this issue if already open.

Screen Shot 2565-08-26 at 19 22 05

@cmsbuild
Copy link
Contributor

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 26, 2022

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

@perrotta
Copy link
Contributor

perrotta commented Aug 26, 2022

assign @cms-sw/mtd-dpg-l2 @cms-sw/dqm-l2

@makortel
Copy link
Contributor

assign dqm, mtd-dpg

@cmsbuild
Copy link
Contributor

New categories assigned: dqm,mtd-dpg

@jfernan2,@fabiocos,@ahmad3213,@parbol,@micsucmed,@rvenditti,@emanueleusai,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fabiocos
Copy link
Contributor

fabiocos commented Sep 6, 2022

I am busy with other issues on the short term, but I am aware of this problem, and I'll come back to this asap.

@perrotta
Copy link
Contributor

It look like that after the merging of #39490 there are no more failing comparisons in the tests for the MTD vertices.
This issue can be closed then

@srimanob
Copy link
Contributor Author

+upgrade

@makortel
Copy link
Contributor

makortel commented Apr 12, 2023

These symptoms occurred again in #41309 (comment) for workflows 39496.0 and 39500.0
image

@slava77
Copy link
Contributor

slava77 commented Apr 12, 2023

differences in empty plots are probably from NaNs

@fabiocos
Copy link
Contributor

the fix for this issue was merged in CMSSW_12_6_0_pre3 , see https://cmssdt.cern.ch/SDT/ReleaseNotes/CMSSW_12/CMSSW_12_6_0_pre3.html
The latest problem appears to happen in CMSSW_12_5_X integration, where the fix was not yet merged.

@makortel
Copy link
Contributor

The latest problem appears to happen in CMSSW_12_5_X integration, where the fix was not yet merged.

Thanks, good point. So the issue is kind of expected, but possibly not worth of addressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants