-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail comparison of the empty simPVZ (MTD vertices) in PR test #39214
Comments
A new Issue was created by @srimanob Phat Srimanobhas. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign upgrade |
New categories assigned: upgrade @AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks |
assign @cms-sw/mtd-dpg-l2 @cms-sw/dqm-l2 |
assign dqm, mtd-dpg |
New categories assigned: dqm,mtd-dpg @jfernan2,@fabiocos,@ahmad3213,@parbol,@micsucmed,@rvenditti,@emanueleusai,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks |
I am busy with other issues on the short term, but I am aware of this problem, and I'll come back to this asap. |
It look like that after the merging of #39490 there are no more failing comparisons in the tests for the MTD vertices. |
+upgrade |
These symptoms occurred again in #41309 (comment) for workflows 39496.0 and 39500.0 |
differences in empty plots are probably from NaNs |
the fix for this issue was merged in CMSSW_12_6_0_pre3 , see https://cmssdt.cern.ch/SDT/ReleaseNotes/CMSSW_12/CMSSW_12_6_0_pre3.html |
Thanks, good point. So the issue is kind of expected, but possibly not worth of addressing. |
This issue is to follow the issue of always fail comparison of the empty simPVZ histogram under MTD vertices.
FYI @fabiocos @perrotta I think we did have a short discussion on this before but I can't find it. We can close this issue if already open.
The text was updated successfully, but these errors were encountered: