Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set SITECONFIG_PATH for runtheMatrix --ibeos option #39314

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

smuzaffar
Copy link
Contributor

This change proposes to set SITECONFIG_PATH pointing to /cvmfs/cms-ib.cern.ch so that runTheMatrix.py --ibeos can read the ibeos cache data. This change is needed after the merge of #37278.

  • Without this change
> runTheMatrix.py -i all -l 4.22 --ibeos
4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN Step4-NOTRUN  - time date Tue Sep  6 10:23:07 2022-date Tue Sep  6 10:20:38 2022; exit: 0 21504 0 0 0
1 0 0 0 0 tests passed, 0 1 0 0 0 failed
  • with this change
> runTheMatrix.py -i all -l 4.22 --ibeos
4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Tue Sep  6 10:31:57 2022-date Tue Sep  6 10:27:29 2022; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39314/32005

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @srimanob, @sunilUIET, @kskovpen, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06cc6d/27358/summary.html
COMMIT: 0ff2e14
CMSSW: CMSSW_12_6_X_2022-09-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39314/27358/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618180
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 can you please revirew this?

@srimanob
Copy link
Contributor

srimanob commented Sep 7, 2022

+Upgrade

Technical PR.

@kskovpen
Copy link
Contributor

kskovpen commented Sep 7, 2022

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

+1

@cmsbuild cmsbuild merged commit 1da2e2f into cms-sw:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants