Update FG HF thresholds to 2022 PbPb

[stahlleiton]

PR description:

This PR updates the values of the HF thresholds in the HCAL TP emulator with those used during the 2022 PbPb run (as documented in https://its.cern.ch/jira/browse/CMSLITDPG-1078 ).

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mitaylor @mandrenguyen

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41239/34965

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimProducers (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @sameasy, @abdoulline, @rovere, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

@Michael-Krohn FYI

[aloeliger]

@stahlleiton forgive my ignorance in this matter, but a quick search for the previous pp_on_AA shows numerous uses throughout CMSSW including DQM and some patCandidates style configurations. I'm assuming that pp_on_AA_2018 and pp_on_PbPb_run3 are ultimately derivatives of this? This will not cause HCAL TPs to drift out of alignment with DQM (for instance) or anything similar will it?

[stahlleiton]

@stahlleiton forgive my ignorance in this matter, but a quick search for the previous pp_on_AA shows numerous uses throughout CMSSW including DQM and some patCandidates style configurations. I'm assuming that pp_on_AA_2018 and pp_on_PbPb_run3 are ultimately derivatives of this? This will not cause HCAL TPs to drift out of alignment with DQM (for instance) or anything similar will it?

Since the era modifiers pp_on_AA_2018 and pp_on_PbPb_run3 are used separately in their corresponding Eras: Run2_2018_pp_on_AA and Run3_pp_on_PbPb, respectively. As long as the correct era is used when using the cmsDriver command, then in principle, the settings should be synchronized across the different processes.

[aloeliger]

Alright. Perfect. Thank you.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19bcdc/31717/summary.html
COMMIT: 8ca4e32
CMSSW: CMSSW_13_1_X_2023-03-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41239/31717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3553709
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3553686
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Please profit of this PR to remove the explicit type declaration for the modified configuration parameters (safer way to modify module configurations). At the same time, I would suggest (but do not take it as a requirement) to more intuitively group together the modifications corresponding to a given era.

That is, overall:

from Configuration.Eras.Modifier_run2_HCAL_2018_cff import run2_HCAL_2018
run2_HCAL_2018.toModify(CaloTPGTranscoder, linearLUTs=True)
run2_HCAL_2018.toModify(HcalTPGCoderULUT, linearLUTs=True)

from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(HcalTPGCoderULUT, applyFixPCC=True)

from Configuration.Eras.Modifier_pp_on_AA_2018_cff import pp_on_AA_2018
pp_on_AA_2018.toModify(CaloTPGTranscoder, FG_HF_thresholds = [15, 19])
pp_on_AA_2018.toModify(HcalTPGCoderULUT, FG_HF_thresholds = [15, 19])

from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3
pp_on_PbPb_run3.toModify(CaloTPGTranscoder, FG_HF_thresholds = [14, 19])
pp_on_PbPb_run3.toModify(HcalTPGCoderULUT, FG_HF_thresholds = [14, 19])

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41239/35009

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #41239 was updated. @epalencia, @cmsbuild, @saumyaphor4252, @aloeliger, @francescobrivio, @cecilecaillol, @tvami can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19bcdc/31764/summary.html
COMMIT: aef6e8c
CMSSW: CMSSW_13_1_X_2023-04-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41239/31764/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3364817
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3364779
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 202 log files, 155 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[stahlleiton]

@perrotta : Are there further changes I should implement in this PR?
If not, I will proceed to synchronize this PR with the corresponding back ports.

[perrotta]

@perrotta : Are there further changes I should implement in this PR? If not, I will proceed to synchronize this PR with the corresponding back ports.

Thank you @stahlleiton
This is fine with me now.
As soon as @cms-sw/l1-l2 and @cms-sw/alca-l2 signe it again we'll merge in master

[aloeliger]

+l1

• looks good from my side

[tvami]

+alca

• the code changes look good
• there are no diffs in the Jenkins tests, I'm a bit surprised to see that since I expected changes due to the threshold update, @stahlleiton can you please clarify?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@tvami the threshold is updated for the 2022 PbPb emulator: I don't think we have RelVals that test it in the jenkins tests

[perrotta]

+1