[12_5_X] Update FG HF thresholds to 2022 PbPb #41251

stahlleiton · 2023-04-01T09:12:38Z

PR description:

This PR updates the values of the HF thresholds in the HCAL TP emulator with those used during the 2022 PbPb run (as documented in https://its.cern.ch/jira/browse/CMSLITDPG-1078 ).

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41239

cmsbuild · 2023-04-01T09:13:01Z

A new Pull Request was created by @stahlleiton (Andre Stahl) for CMSSW_12_5_X.

It involves the following packages:

SimCalorimetry/HcalTrigPrimProducers (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @sameasy, @abdoulline, @rovere, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Update FG HF thresholds to 2022 PbPb #41239

aloeliger · 2023-04-01T09:37:33Z

Backport of #41239

aloeliger · 2023-04-01T09:38:02Z

please test

cmsbuild · 2023-04-01T12:30:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5129c2/31726/summary.html
COMMIT: cb15f31
CMSSW: CMSSW_12_5_X_2023-03-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41251/31726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 9 lines from the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3724047
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3724003
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 216 log files, 167 edm output root files, 51 DQM output files
TriggerResults: no differences found

aloeliger · 2023-04-02T05:32:11Z

@stahlleiton Please implement the changes seen in #41239 here as well.

perrotta · 2023-04-04T09:58:47Z

I imagine that no serious MC production for HI in >= 2022 was already started with 12_5_X, and therefore this PR (once updated) can be backported without the need of a dedicated process modifier: but could you please confirm?

stahlleiton · 2023-04-04T10:27:25Z

I imagine that no serious MC production for HI in >= 2022 was already started with 12_5_X, and therefore this PR (once updated) can be backported without the need of a dedicated process modifier: but could you please confirm?

The campaign for the 2022 PbPb MC production has been set up in McM and is currently running the pilot job for the GEN-SIM step ( https://cms-pdmv.cern.ch/mcm/requests?member_of_campaign=HINPbPbSpring23GS&page=0&shown=127 ).
So at the moment, the full production has not yet been performed. The era used for 2022 is: Run3_pp_on_PbPb

cmsbuild · 2023-04-04T10:51:29Z

Pull request #41251 was updated. @epalencia, @cmsbuild, @saumyaphor4252, @aloeliger, @francescobrivio, @cecilecaillol, @tvami can you please check and sign again.

tvami · 2023-04-04T11:55:22Z

@cmsbuild , please test

cmsbuild · 2023-04-04T13:13:09Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5129c2/31792/summary.html
COMMIT: 9e6b4c8
CMSSW: CMSSW_12_5_X_2023-04-02-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41251/31792/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 160.1

cmsbuild · 2023-04-04T17:42:55Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5129c2/31800/summary.html
COMMIT: 9e6b4c8
CMSSW: CMSSW_12_5_X_2023-04-02-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41251/31800/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3724047
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3724015
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 216 log files, 167 edm output root files, 51 DQM output files
TriggerResults: no differences found

stahlleiton · 2023-04-04T18:09:52Z

Not sure I understand the error. Is the timeout related to this PR?

aloeliger · 2023-04-04T18:11:29Z

No. To the best of my knowledge it just happens sometimes.

aloeliger · 2023-04-04T18:11:35Z

please test

cmsbuild · 2023-04-04T21:40:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5129c2/31810/summary.html
COMMIT: 9e6b4c8
CMSSW: CMSSW_12_5_X_2023-04-02-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41251/31810/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3724047
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3724015
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 216 log files, 167 edm output root files, 51 DQM output files
TriggerResults: no differences found

tvami · 2023-04-04T21:43:37Z

+alca

aloeliger · 2023-04-05T07:03:04Z

+l1

cmsbuild · 2023-04-05T07:03:28Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-04-05T07:24:33Z

@cms-sw/pdmv-l2 before merging this PR and having it forgotten: do you suggest to build a CMSSW_12_5_5_patch1 right after, so that we are sure that this PR is picked during the forthcoming HI productions requested in 12_5_X? Or do you think that there are other updates expected, and we'll combine them all together in the next (patch) release before that production starts?

kskovpen · 2023-04-05T08:15:45Z

@cms-sw/pdmv-l2 before merging this PR and having it forgotten: do you suggest to build a CMSSW_12_5_5_patch1 right after, so that we are sure that this PR is picked during the forthcoming HI productions requested in 12_5_X? Or do you think that there are other updates expected, and we'll combine them all together in the next (patch) release before that production starts?

maybe @jmartinb would have a suggestion here

rappoccio · 2023-04-05T17:10:00Z

+1

perrotta · 2023-04-06T08:40:22Z

Since this PR is now merged in 12_5_X, let build the patch release, so that we do not forget this update for the coming HI productions: see #41295

cmsbuild added this to the CMSSW_12_5_X milestone Apr 1, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending labels Apr 1, 2023

cmsbuild added the backport label Apr 1, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 1, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 1, 2023

Updated the FG HF thresholds for 2022 PbPb

9e6b4c8

stahlleiton force-pushed the FH_HF_Update_CMSSW_12_5_5 branch from cb15f31 to 9e6b4c8 Compare April 4, 2023 10:51

cmsbuild added alca-pending tests-pending and removed tests-approved labels Apr 4, 2023

cmsbuild added tests-started backport-ok and removed tests-pending backport labels Apr 4, 2023

cmsbuild removed the tests-started label Apr 4, 2023

cmsbuild added the tests-started label Apr 4, 2023

cmsbuild added tests-rejected and removed tests-started labels Apr 4, 2023

cmsbuild added tests-started and removed tests-rejected labels Apr 4, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 4, 2023

cmsbuild added alca-approved and removed alca-pending labels Apr 4, 2023

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Apr 5, 2023

cmsbuild added orp-approved and removed orp-pending labels Apr 5, 2023

cmsbuild merged commit 10fa4ed into cms-sw:CMSSW_12_5_X Apr 5, 2023

stahlleiton deleted the FH_HF_Update_CMSSW_12_5_5 branch April 5, 2023 23:22

perrotta mentioned this pull request Apr 6, 2023

Build CMSSW_12_5_5_patch1 #41295

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12_5_X] Update FG HF thresholds to 2022 PbPb #41251

[12_5_X] Update FG HF thresholds to 2022 PbPb #41251

stahlleiton commented Apr 1, 2023

cmsbuild commented Apr 1, 2023 •

edited

Loading

aloeliger commented Apr 1, 2023

aloeliger commented Apr 1, 2023

cmsbuild commented Apr 1, 2023

aloeliger commented Apr 2, 2023

perrotta commented Apr 4, 2023

stahlleiton commented Apr 4, 2023 •

edited

Loading

cmsbuild commented Apr 4, 2023

tvami commented Apr 4, 2023

cmsbuild commented Apr 4, 2023

cmsbuild commented Apr 4, 2023

stahlleiton commented Apr 4, 2023

aloeliger commented Apr 4, 2023

aloeliger commented Apr 4, 2023

cmsbuild commented Apr 4, 2023

tvami commented Apr 4, 2023

aloeliger commented Apr 5, 2023

cmsbuild commented Apr 5, 2023

perrotta commented Apr 5, 2023

kskovpen commented Apr 5, 2023

rappoccio commented Apr 5, 2023

perrotta commented Apr 6, 2023

[12_5_X] Update FG HF thresholds to 2022 PbPb #41251

[12_5_X] Update FG HF thresholds to 2022 PbPb #41251

Conversation

stahlleiton commented Apr 1, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Apr 1, 2023 • edited Loading

aloeliger commented Apr 1, 2023

aloeliger commented Apr 1, 2023

cmsbuild commented Apr 1, 2023

Comparison Summary

aloeliger commented Apr 2, 2023

perrotta commented Apr 4, 2023

stahlleiton commented Apr 4, 2023 • edited Loading

cmsbuild commented Apr 4, 2023

tvami commented Apr 4, 2023

cmsbuild commented Apr 4, 2023

RelVals

cmsbuild commented Apr 4, 2023

RelVals-INPUT

Comparison Summary

stahlleiton commented Apr 4, 2023

aloeliger commented Apr 4, 2023

aloeliger commented Apr 4, 2023

cmsbuild commented Apr 4, 2023

Comparison Summary

tvami commented Apr 4, 2023

aloeliger commented Apr 5, 2023

cmsbuild commented Apr 5, 2023

perrotta commented Apr 5, 2023

kskovpen commented Apr 5, 2023

rappoccio commented Apr 5, 2023

perrotta commented Apr 6, 2023

cmsbuild commented Apr 1, 2023 •

edited

Loading

stahlleiton commented Apr 4, 2023 •

edited

Loading